From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#52605: [PATCH] Add isearch-emoji-by-name Date: Sat, 18 Dec 2021 21:07:38 +0200 Message-ID: <83lf0hag05.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31761"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52605@debbugs.gnu.org To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 18 20:08:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myf3w-0007zF-S6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Dec 2021 20:08:09 +0100 Original-Received: from localhost ([::1]:32920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myf3v-0002CH-P2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Dec 2021 14:08:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myf3q-0002C7-1d for bug-gnu-emacs@gnu.org; Sat, 18 Dec 2021 14:08:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60538) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myf3p-0004Ru-Pg for bug-gnu-emacs@gnu.org; Sat, 18 Dec 2021 14:08:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1myf3p-0008DI-KX for bug-gnu-emacs@gnu.org; Sat, 18 Dec 2021 14:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Dec 2021 19:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52605 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52605-submit@debbugs.gnu.org id=B52605.163985447631557 (code B ref 52605); Sat, 18 Dec 2021 19:08:01 +0000 Original-Received: (at 52605) by debbugs.gnu.org; 18 Dec 2021 19:07:56 +0000 Original-Received: from localhost ([127.0.0.1]:43851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myf3k-0008Cv-E2 for submit@debbugs.gnu.org; Sat, 18 Dec 2021 14:07:56 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myf3i-0008Cf-Sh for 52605@debbugs.gnu.org; Sat, 18 Dec 2021 14:07:55 -0500 Original-Received: from [2001:470:142:3::e] (port=36482 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myf3c-0004Qr-UJ; Sat, 18 Dec 2021 14:07:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=DXFbDjZRMMUo+QA2q46pfvYioH6fwAVWcYnPuz+9dk8=; b=NzGRKMnZ2SaKA796LtFp UL9ivKIhdGjtjyIKEIPvSCeyZYMKHEGT2V9IQfpH8/4Y5J16MNDX66OhxxBI9YKf5K8CGifWP2hc4 zCPajlbB0F6iSm/WdmckJZUCAcTUKNyxPheVuyjY9ilDW2I4Y6sbnGft+L6VHf24rCzXg0szLbFxZ Ipd9nhJ8QK9x3TcwJj6hmKGN98pgyOZHj3xdGcrrDKPQnZalb2ouEGul886Q+8QQCAm5wiLVetybg mvJOrAKhkECdAietXniyBMNLwUwUQ4eEtP8cVVp3d7fiG/SVyYJl02TIHdVARb/oltkzv641lbkG3 dqSMQLhlJ6oMCQ==; Original-Received: from [87.69.77.57] (port=2388 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myf3c-00079l-QE; Sat, 18 Dec 2021 14:07:49 -0500 In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222621 Archived-At: > Date: Sat, 18 Dec 2021 19:55:02 +0100 > From: Daniel Martín via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > This patch adds support for searching a buffer for Emojis without > needing to copy and paste them from another buffer or leaving isearch. > Isearch already provides some methods to search for non-ASCII > characters, so I decided to extend the package to search for Emoji as > well. > > With this patch, during an incremental search, if you press 'C-x 8 e > RET', it will ask you for an Emoji character by name and insert it into > the search string. A prefix argument N will insert N copies of the > character. Thanks. > +@item > +@findex isearch-emoji-by-name > +@kindex C-x 8 e RET @r{(Incremental Search)} > +Type @kbd{C-x 8 e @key{RET}} (@code{isearch-emoji-by-name}), followed > +by the name of an Emoji. This adds the specified Emoji into the > +search string. This should explain what kind of "emoji names" the feature accepts. It is entirely unclear from the text. > +*** New command 'isearch-emoji-by-name'. > +It is bound to 'C-x 8 e RET' during an incremental search and it > +inserts an Emoji character into the search string. Likewise here. The NEWS entry doesn't even mention that Emoji are specified by their names. > +(defun isearch-emoji-by-name (&optional count) > + "Read an Emoji and add it to the search string. "Read and Emoji name and add it to the search string." Likewise here, the doc string should clarify what kind of names are acceptable. I would also mention that completion is provided while typing the name.