From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes Date: Mon, 28 Feb 2022 15:28:03 +0200 Message-ID: <83lexvm87w.fsf@gnu.org> References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> <87o82rqqjs.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38170"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, larsi@gnus.org, 54190@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 28 14:29:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOg5S-0009iL-1X for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Feb 2022 14:29:14 +0100 Original-Received: from localhost ([::1]:49302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOg5Q-00061K-T3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Feb 2022 08:29:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOg5G-0005xs-Od for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 08:29:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38394) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOg5G-0002te-G2 for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 08:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nOg5G-0007yX-Cz for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 08:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Feb 2022 13:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54190-submit@debbugs.gnu.org id=B54190.164605490130608 (code B ref 54190); Mon, 28 Feb 2022 13:29:02 +0000 Original-Received: (at 54190) by debbugs.gnu.org; 28 Feb 2022 13:28:21 +0000 Original-Received: from localhost ([127.0.0.1]:60524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOg4b-0007xb-Dk for submit@debbugs.gnu.org; Mon, 28 Feb 2022 08:28:21 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOg4Z-0007xO-PK for 54190@debbugs.gnu.org; Mon, 28 Feb 2022 08:28:20 -0500 Original-Received: from [2001:470:142:3::e] (port=40200 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOg4U-0002kb-05; Mon, 28 Feb 2022 08:28:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DF11SAI/yibQTnLoXti20sQNtY0cz441D3sZF0pGkEU=; b=BH0kFTLaGCZe Qmr9989O8ukrQ+dxXRdOlVkPAIXCuxJ4a3ZZuGDrPRyCq/IuqtS1Hd7JxSG4A6hrgqoEdQSgQ72cN COQMsEnG2qDI1NphK2yRu5nrA4ipi63mnuxBA/WpBHKfn/8ScCOW0U3s/vsoTaW/52u5ASC3HPnJH H5VHmEApXQTlHUuUswzc4pn3ZOwpDAEt+I01Uw8xc6mkmrdcwmbGe5yrIFDnFanjEqdfxo6lNtFh6 6zmVJ3lEErUyt0OoRPyPRsQ4Y/B/rmrrIPLlwJjcIqEm3vXCzvIYHkBGf+vBIGN1LP2M2L2srgoUZ frgZX/7KWT4I5GIIXtCRAA==; Original-Received: from [87.69.77.57] (port=1806 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOg4T-0001IO-CP; Mon, 28 Feb 2022 08:28:13 -0500 In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227810 Archived-At: > Cc: Jim Porter , 54190@debbugs.gnu.org > Date: Mon, 28 Feb 2022 08:18:26 -0500 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > diff --git a/lisp/eshell/esh-var.el b/lisp/eshell/esh-var.el > > index 96838d4132..7388279f15 100644 > > --- a/lisp/eshell/esh-var.el > > +++ b/lisp/eshell/esh-var.el > > @@ -463,8 +463,8 @@ eshell-parse-variable-ref > > (eshell-as-subcommand ,(eshell-parse-command cmd)) > > (ignore > > (nconc eshell-this-command-hook > > - (list (function (lambda () > > - (delete-file ,temp)))))) > > + (list (lambda () > > + (delete-file ,temp))))) > > (quote ,temp))) > > (goto-char (1+ end))))))) > > ((eq (char-after) ?\() > > > > > > Trying to follow the logic of how this is eventually evaluated isn't, > > er, obvious, but I'm not sure how that change could break anything, > > either. Perhaps Stefan has a comment; added to the CCs. > > Looks like a bug somewhere in the `eshell-do-eval` machinery, yes. > Until we find the problem (or rewrite `eshell-do-eval` on top of the CPS > converter of `generator.el`), I think reverting this change (and adding > a comment pointing to this bug) sounds like a great plan. I agree. We should revert this on the release branch, since this is a regression wrt Emacs 27. Thanks.