From: Eli Zaretskii <eliz@gnu.org>
To: Ergus <spacibba@aol.com>
Cc: 54450-done@debbugs.gnu.org
Subject: bug#54450: 29.0.50; redisplay--pre-redisplay-functions issue
Date: Sat, 19 Mar 2022 09:22:05 +0200 [thread overview]
Message-ID: <83lex6fluq.fsf@gnu.org> (raw)
In-Reply-To: <20220318212524.53sgxqnw2a67xsfe@Ergus> (message from Ergus on Fri, 18 Mar 2022 22:25:24 +0100)
> Date: Fri, 18 Mar 2022 22:25:24 +0100
> From: Ergus <spacibba@aol.com>
> Cc: 54450@debbugs.gnu.org
>
> On Fri, Mar 18, 2022 at 08:54:00PM +0200, Eli Zaretskii wrote:
> >> Date: Fri, 18 Mar 2022 20:38:18 +0200
> >> From: Eli Zaretskii <eliz@gnu.org>
> >> Cc: 54450@debbugs.gnu.org
> >>
> >> > Yes, this could solve the issue for the region, but not in general for
> >> > redisplay--update-cursor-face-highlight which was the initial problem
> >> > with Juri's code. Same for any other function that goes into the
> >> > pre-redisplay-functions hook.
> >>
> >> I asked for a test case, and this is what you gave me.
> >>
> >> If there's another test case, please show it.
> >
> >But before you do, please try the alternative patch below:
> >
> >diff --git a/src/xdisp.c b/src/xdisp.c
> >index 5cb5839..6d8d4aa 100644
> >--- a/src/xdisp.c
> >+++ b/src/xdisp.c
> >@@ -13211,7 +13211,8 @@ prepare_menu_bars (void)
> > struct window *w = XWINDOW (this);
> > if (w->redisplay
> > || XFRAME (w->frame)->redisplay
> >- || XBUFFER (w->contents)->text->redisplay)
> >+ || XBUFFER (w->contents)->text->redisplay
> >+ || w->last_point != marker_position (w->pointm))
> > {
> > windows = Fcons (this, windows);
> > }
>
> Yes, now this seems to solve the issue for the two use cases described.
Thanks, I installed a slightly modified variant of this on the
emacs-28 branch.
prev parent reply other threads:[~2022-03-19 7:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87pmmjw9ru.fsf.ref@aol.com>
2022-03-18 15:38 ` bug#54450: 29.0.50; redisplay--pre-redisplay-functions issue Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-18 17:01 ` Eli Zaretskii
2022-03-18 17:42 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-18 18:38 ` Eli Zaretskii
2022-03-18 18:52 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-18 19:46 ` Eli Zaretskii
2022-03-18 18:54 ` Eli Zaretskii
2022-03-18 21:25 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-19 7:22 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lex6fluq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=54450-done@debbugs.gnu.org \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).