From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55156: [PATCH] eval.c: New functions `defvar-f` and `defconst-f` Date: Thu, 26 May 2022 08:01:27 +0300 Message-ID: <83leuoq448.fsf@gnu.org> References: <83sfpxbwkg.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21239"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55156@debbugs.gnu.org, larsi@gnus.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 26 07:02:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nu5dZ-0005Jx-QR for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 May 2022 07:02:17 +0200 Original-Received: from localhost ([::1]:45996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nu5dY-0004Oe-Cz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 May 2022 01:02:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nu5dK-0004O2-W2 for bug-gnu-emacs@gnu.org; Thu, 26 May 2022 01:02:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34713) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nu5dK-0006sy-NF for bug-gnu-emacs@gnu.org; Thu, 26 May 2022 01:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nu5dK-0004mu-IT for bug-gnu-emacs@gnu.org; Thu, 26 May 2022 01:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 May 2022 05:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55156 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55156-submit@debbugs.gnu.org id=B55156.165354131418388 (code B ref 55156); Thu, 26 May 2022 05:02:02 +0000 Original-Received: (at 55156) by debbugs.gnu.org; 26 May 2022 05:01:54 +0000 Original-Received: from localhost ([127.0.0.1]:56843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nu5dC-0004mW-JG for submit@debbugs.gnu.org; Thu, 26 May 2022 01:01:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nu5d7-0004mD-BJ for 55156@debbugs.gnu.org; Thu, 26 May 2022 01:01:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56032) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nu5d2-0006qS-0U; Thu, 26 May 2022 01:01:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6QqB78JbM+e/wtfSTpWJ7XvEFBtlZvFmttIT6cpfmgw=; b=PbLSxV9n2yJD 81rhuZ5W9VNK0I3dLVLi6JbN0EUPPDALoM6pSASh9ba0yYuUTNSzpgumGs5Z8TrvSntf/RqVdwdYJ AW3XN1qtLe7BgCTIPfV+Xx0IYSqfAhSRS6BH3sPLWRexaXIlzFExZ1+iYlwdzqNI9WJXz2moFcMoA GajMQRI5iZKeMTnFgVTuvLaJYCSjEUXTgDn/RrRwTup8V8pAmODXQh4LrTznhMuykQB+JNDXW+krb Axlnvf0Ta3y+hrzjH5AhO2jgk+24peONUVZn4+SWyIi9cTEzV5pBvTwnocnMVjF9MxjCgkbmteqZn /si5rj3ZoaCy9NCdY6vqbw==; Original-Received: from [87.69.77.57] (port=2979 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nu5cu-0002P7-IC; Thu, 26 May 2022 01:01:41 -0400 In-Reply-To: (message from Stefan Monnier on Wed, 25 May 2022 16:38:45 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233087 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii , Lars Ingebrigtsen > Date: Wed, 25 May 2022 16:38:45 -0400 LGTM, with a minor nit: > * src/eval.c (defvar, Fdefvar_1, Fdefconst_1): New functions, extracted from > `Fdef(var|const)`. ^^^^^^^^^^^ [...] > (byte-compile-defvar): Simplify using the new `def(car|const)-1` functions. ^^^^^^^^^^^ Can we please not use such "shorthands" in the log messages? They make it much harder to search for changes related to some symbol, and much easier to miss some changes. I understand the urge to type less, but M-/ is available to alleviate that, and usually does the job for me. Thanks.