bug#56259: 29.0.50; Illegal -layoutSubtreeIfNeeded on NS

bug#56259: 29.0.50; Illegal -layoutSubtreeIfNeeded on NS

[Gerd Möllmann]

On macOS 12.4, selecting Options -> Set Default Font from the menu bar 
reproducibly prints a message to the terminal:

emacs[76309:7042282] It's not legal to call -layoutSubtreeIfNeeded on
a view which is already being laid out.  If you are implementing the
view's -layout method, you can call -[super layout] instead. Break on
void _NSDetectedLayoutRecursion(void) to debug.  This will be logged
only once.  This may break in the future.

Hopefully nobody get's sued because of that illegal action...

Backtrace from lldb:

 * frame #0: 0x000000019e2f5f40 AppKit`_NSDetectedLayoutRecursion
    frame #1: 0x000000019dac4148 AppKit`-[NSWindow(NSConstraintBasedLayout) _layoutViewTree] + 148
    frame #2: 0x000000019dac11d0 AppKit`-[NSWindow _oldPlaceWindow:fromServer:] + 584
    frame #3: 0x000000019dac0050 AppKit`-[NSWindow _setFrameCommon:display:fromServer:] + 2220
    frame #4: 0x000000019db854cc AppKit`-[NSThemeFrame _growWindowReshapeContentAndToolbarView:withOldToolbarFrameSize:animate:] + 1232
    frame #5: 0x000000019db84ddc AppKit`-[NSThemeFrame _reshapeContentAndToolbarView:withOldToolbarFrameSize:resizeWindow:animate:] + 300
    frame #6: 0x000000019db738bc AppKit`-[NSThemeFrame _toolbarFrameSizeChanged:oldSize:] + 76
    frame #7: 0x000000019db737f4 AppKit`-[NSWindow _toolbarFrameSizeChanged:oldSize:] + 96
    frame #8: 0x000000019db68870 AppKit`-[NSToolbarView _layoutDirtyItemViewersAndTileToolbar] + 428
    frame #9: 0x000000019db8b114 AppKit`-[NSToolbarView layout] + 88
    frame #10: 0x000000019dac5700 AppKit`_NSViewLayout + 688
    frame #11: 0x000000019dac5178 AppKit`-[NSView _layoutSubtreeWithOldSize:] + 380
    frame #12: 0x000000019dac52e4 AppKit`-[NSView _layoutSubtreeWithOldSize:] + 744
    frame #13: 0x000000019dac52e4 AppKit`-[NSView _layoutSubtreeWithOldSize:] + 744
    frame #14: 0x000000019dac52e4 AppKit`-[NSView _layoutSubtreeWithOldSize:] + 744
    frame #15: 0x000000019dac4600 AppKit`-[NSView _layoutSubtreeIfNeededAndAllowTemporaryEngine:] + 996
    frame #16: 0x000000019dac4148 AppKit`-[NSWindow(NSConstraintBasedLayout) _layoutViewTree] + 148
    frame #17: 0x000000019db3b8ec AppKit`-[NSWindow(NSConstraintBasedLayout) layoutIfNeeded] + 308
    frame #18: 0x000000019dba7388 AppKit`-[NSWindow _setUpFirstResponderBeforeBecomingVisible] + 84
    frame #19: 0x000000019dba6750 AppKit`-[NSWindow _doWindowWillBeVisibleAsSheet:] + 164
    frame #20: 0x000000019dba507c AppKit`-[NSWindow _reallyDoOrderWindowAboveOrBelow:relativeTo:findKey:forCounter:force:isModal:] + 1232
    frame #21: 0x000000019dba4790 AppKit`-[NSWindow _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:] + 132
    frame #22: 0x000000019dba377c AppKit`-[NSWindow _doOrderWindow:relativeTo:findKey:forCounter:force:isModal:] + 324
    frame #23: 0x000000010088d424 emacs`-[EmacsView showFontPanel](self=0x0000000108431400, _cmd="showFontPanel") at nsterm.m:6585:3
    frame #24: 0x000000010090d670 emacs`Fx_select_font(frame=0x0000000000000000, ignored=0x0000000000000000) at nsfns.m:1662:22

A related bug might be bug#53481 (status done, fixed by Alan Third).

bug#56259: 29.0.50; Illegal -layoutSubtreeIfNeeded on NS

[Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Gerd Möllmann <gerd.moellmann@gmail.com> writes:

> On macOS 12.4, selecting Options -> Set Default Font from the menu bar 
> reproducibly prints a message to the terminal:
>
> emacs[76309:7042282] It's not legal to call -layoutSubtreeIfNeeded on
> a view which is already being laid out.  If you are implementing the
> view's -layout method, you can call -[super layout] instead. Break on
> void _NSDetectedLayoutRecursion(void) to debug.  This will be logged
> only once.  This may break in the future.
>

I wonder if this is a bug in macOS 12.4 (concretely, in NSFontManager's
orderFrontFontPanel) and not in Emacs.  For example, I can reproduce the
same warning if I try to open the Fonts panel in the standard TextEdit
app created by Apple.

bug#56259: 29.0.50; Illegal -layoutSubtreeIfNeeded on NS

[Eli Zaretskii]

> Cc: 56259@debbugs.gnu.org
> Date: Mon, 27 Jun 2022 17:05:16 +0200
> From:  Daniel Martín via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> Gerd Möllmann <gerd.moellmann@gmail.com> writes:
> 
> > On macOS 12.4, selecting Options -> Set Default Font from the menu bar 
> > reproducibly prints a message to the terminal:
> >
> > emacs[76309:7042282] It's not legal to call -layoutSubtreeIfNeeded on
> > a view which is already being laid out.  If you are implementing the
> > view's -layout method, you can call -[super layout] instead. Break on
> > void _NSDetectedLayoutRecursion(void) to debug.  This will be logged
> > only once.  This may break in the future.
> >
> 
> I wonder if this is a bug in macOS 12.4 (concretely, in NSFontManager's
> orderFrontFontPanel) and not in Emacs.  For example, I can reproduce the
> same warning if I try to open the Fonts panel in the standard TextEdit
> app created by Apple.

Then let's sue Apple for its illegal calls.

bug#56259: 29.0.50; Illegal -layoutSubtreeIfNeeded on NS

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Gerd Möllmann <gerd.moellmann@gmail.com> writes:

> On macOS 12.4, selecting Options -> Set Default Font from the menu bar 
> reproducibly prints a message to the terminal:
>
> emacs[76309:7042282] It's not legal to call -layoutSubtreeIfNeeded on
> a view which is already being laid out.  If you are implementing the
> view's -layout method, you can call -[super layout] instead. Break on
> void _NSDetectedLayoutRecursion(void) to debug.  This will be logged
> only once.  This may break in the future.
>
> Hopefully nobody get's sued because of that illegal action...

I get the feeling this is one of Apple's bugs, since it happens to every
program's fonts panel, including those that come with Mac OS.

So let's sue Apple!

bug#56259: 29.0.50; Illegal -layoutSubtreeIfNeeded on NS

[Gerd Möllmann]

[-- Attachment #1.1: Type: text/plain, Size: 282 bytes --]



> On 2022-06-28,, at 3:24 , Po Lu <luangruo@yahoo.com> wrote:
> 
> So let's sue Apple!

We should first try in good faith, that always makes a good impression in court.

We could assign the bug to Tim Cook and ask him to solve it. With a deadline for the fix, of course.

[-- Attachment #1.2: Type: text/html, Size: 1182 bytes --]

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 874 bytes --]

bug#56259: 29.0.50; Illegal -layoutSubtreeIfNeeded on NS

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > > I wonder if this is a bug in macOS 12.4 (concretely, in NSFontManager's
  > > orderFrontFontPanel) and not in Emacs.  For example, I can reproduce the
  > > same warning if I try to open the Fonts panel in the standard TextEdit
  > > app created by Apple.

  > Then let's sue Apple for its illegal calls.

None of these things is "illegal" -- that's the wrong word.
I'm not sure what people mean by using it in this context,
but I don't think there is a law against it.

Apple surely has no legal obligation to implement the feature we
would like to use, so there is no basis for a lawsuit against Apple.

This is why we urge people not to use the word "illegal" to say
that some way of using a program is considered invalid or not supported.
See the node GNU Manuals in the GNU Coding Standards.

-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#56259: 29.0.50; Illegal -layoutSubtreeIfNeeded on NS

[Eli Zaretskii]

> From: Richard Stallman <rms@gnu.org>
> Cc: mardani29@yahoo.es, gerd.moellmann@gmail.com,
> 	56259@debbugs.gnu.org
> Date: Wed, 29 Jun 2022 23:09:10 -0400
> 
>   > > I wonder if this is a bug in macOS 12.4 (concretely, in NSFontManager's
>   > > orderFrontFontPanel) and not in Emacs.  For example, I can reproduce the
>   > > same warning if I try to open the Fonts panel in the standard TextEdit
>   > > app created by Apple.
> 
>   > Then let's sue Apple for its illegal calls.
> 
> None of these things is "illegal" -- that's the wrong word.

There's nothing illegal in joking about that, either.

bug#56259: 29.0.50; Illegal -layoutSubtreeIfNeeded on NS

[Gerd Möllmann]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]



> On 2022-06-30,, at 7:20 , Eli Zaretskii <eliz@gnu.org> wrote:
> 
>>> Then let's sue Apple for its illegal calls.
>> 
>> None of these things is "illegal" -- that's the wrong word.
> 
> There's nothing illegal in joking about that, either.

And there could be a lot of money in it for the FSF.

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 874 bytes --]

bug#56259: 29.0.50; Illegal -layoutSubtreeIfNeeded on NS

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > > None of these things is "illegal" -- that's the wrong word.

  > There's nothing illegal in joking about that, either.

That joking is not illegal, but it can be confusing.
(I couldn't tell it was a joke.)

-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#56259: 29.0.50; Illegal -layoutSubtreeIfNeeded on NS

[Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors]

tags 56259 notabug
close 56259
quit

I think the general consensus was that this message is a bug in some
Apple framework and not in Emacs, so I'm closing the bug report.

bug#58540: 29.0.50; While opening the font dialog

[Stefan Kangas]

Daniel Martín <mardani29@yahoo.es> writes:

> tags 56259 notabug
> close 56259
> quit
>
> I think the general consensus was that this message is a bug in some
> Apple framework and not in Emacs, so I'm closing the bug report.

The bug was left open, so I'm closing it now.