From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50951: 28.0.50; Urdu text is not displayed correctly Date: Mon, 26 Sep 2022 10:18:50 +0300 Message-ID: <83leq6li1x.fsf@gnu.org> References: <83mtnsc63i.fsf@gnu.org> <83sfxjbox7.fsf@gnu.org> <87pmsnwlvo.fsf@igel.home> <837devbgrl.fsf@gnu.org> <8335pjbewj.fsf@gnu.org> <83zgrr9zn1.fsf@gnu.org> <87edwq7srx.fsf_-_@gnus.org> <87y1uy6mn5.fsf@zohomail.eu> <83wnaij974.fsf@gnu.org> <87tu5m6jrw.fsf@zohomail.eu> <835yhzifuw.fsf@gnu.org> <87o7vqxuvs.fsf@gmail.com> <87h71gwpr5.fsf@zohomail.eu> <87mtayymk5.fsf@zohomail.eu> <835yhixq1r.fsf@gnu.org> <83h710t1ez.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4881"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rahguzar@zohomail.eu, larsi@gnus.org, 50951@debbugs.gnu.org, visuweshm@gmail.com To: YAMAMOTO Mitsuharu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 26 09:20:36 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ociPr-00018z-GG for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Sep 2022 09:20:35 +0200 Original-Received: from localhost ([::1]:55872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ociPq-000884-3j for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Sep 2022 03:20:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ociPK-000873-To for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 03:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50045) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ociPK-0004rF-BD for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 03:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ociPJ-00083A-Vw for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 03:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Sep 2022 07:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50951 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 50951-submit@debbugs.gnu.org id=B50951.166417675430879 (code B ref 50951); Mon, 26 Sep 2022 07:20:01 +0000 Original-Received: (at 50951) by debbugs.gnu.org; 26 Sep 2022 07:19:14 +0000 Original-Received: from localhost ([127.0.0.1]:49123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ociOX-00081z-NQ for submit@debbugs.gnu.org; Mon, 26 Sep 2022 03:19:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ociOT-00081i-G5 for 50951@debbugs.gnu.org; Mon, 26 Sep 2022 03:19:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58988) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ociOL-0004lP-Kg; Mon, 26 Sep 2022 03:19:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tzltRoqPfRLqes8nc8534LvGhWQdwM2DBnSztYEb3U8=; b=fqkmMvvr58O2 BcpkK8K0or4Acskv2zgUEAxp1z9vPHnOVzjKBs3pbgM4KI9kazc1AYTkotDZQiMtjCMBPVu1lCohr fLumKCBxPUp17kAeHBn4ZBuHa6UtYPIfjzaivQaMIjgqCJst/kDgmpTVevG2clRqWTtamVmbaOAmH oGwA+HaCqorUlYI9Cbyb2JmUGI8aFQX1PCKtxhsgodGB7eejPxY0KBSrUibr0NfxIQuBzpnex6p5l aYbkIj7EKP3TJ0NuBm99UNFt2rgn/6Py8mN/q+n0rbpaP6VPJh67WR7PwowjAY3hnjuo6+qKgc0o4 qlk/jX96LY74BGwuzQ3Xbw==; Original-Received: from [87.69.77.57] (port=4223 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ociOL-0007IN-1P; Mon, 26 Sep 2022 03:19:01 -0400 In-Reply-To: (message from YAMAMOTO Mitsuharu on Sun, 25 Sep 2022 16:18:26 +0900) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243623 Archived-At: > Date: Sun, 25 Sep 2022 16:18:26 +0900 > From: YAMAMOTO Mitsuharu > Cc: rahguzar@zohomail.eu, visuweshm@gmail.com, larsi@gnus.org, > 50951@debbugs.gnu.org > > > Also, I asked whether you could elaborate on the rationale for > > adjusting the zero width to be 1 pixel, and I don't think you > > answered that particular question. What you are saying (AFAIU) is > > that heuristically the results of using this adjustment are better, > > at least in this case. I don't argue with that, but I wonder > > whether there's some rationale for this that isn't just heuristics? > > IOW, do you know how come hb-view doesn't have this problem? what do > > we do that produces the zero width where hb-view doesn't? > > The output of hb-view was in PDF, and its coordinate system does not > directly correspond to the integral number of physical pixels unlike > in Emacs. > > The display engine of Emacs only accepts positive integer as > pixel-width of a glyph (in Emacs terminology). If the actual grapheme > cluster has width zero (after rounding), then it is replaced to some > positive integer (space width) in gui_produce_glyphs. Because some > grapheme cluster in the result of shaping can be in very small width > and rounded to 0, adjusting it to 1 is almost the best approximation. OK, thanks. Please install your patch on the master branch.