From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server Date: Fri, 11 Nov 2022 14:01:54 +0200 Message-ID: <83leohpuml.fsf@gnu.org> References: <8cf8ba5d-c604-b2dc-274a-7597b19fb73f@dfreeman.email> <87ilk5xq01.fsf@gmail.com> <87r0yrwfn3.fsf@gmail.com> <37716e41-5955-99f6-5204-e760a716fbf6@yandex.ru> <9bb290c8-f000-31d8-265d-b5441c33eb38@dfreeman.email> <4d50b820-7053-75eb-5b11-d3d36a02b013@dfreeman.email> <87v8nxsrq6.fsf@gmail.com> <87cza40xgs.fsf@dfreeman.email> <83edubrvf0.fsf@gnu.org> <87cz9v9irh.fsf@gmail.com> <83o7terf9a.fsf@gnu.org> <87k042tqze.fsf@dfreeman.email> <83o7tdq4f2.fsf@gnu.org> <87sfip7rkt.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29224"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58790@debbugs.gnu.org, felician.nemeth@gmail.com, stefankangas@gmail.com, danny@dfreeman.email, dgutov@yandex.ru To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 11 13:02:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otSje-0007PB-3e for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Nov 2022 13:02:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otSjT-00018T-Gp; Fri, 11 Nov 2022 07:02:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otSjS-00018D-MM for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 07:02:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otSjS-0001ns-Dd for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 07:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otSjS-0001JA-25 for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 07:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Nov 2022 12:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58790 X-GNU-PR-Package: emacs Original-Received: via spool by 58790-submit@debbugs.gnu.org id=B58790.16681681215024 (code B ref 58790); Fri, 11 Nov 2022 12:02:02 +0000 Original-Received: (at 58790) by debbugs.gnu.org; 11 Nov 2022 12:02:01 +0000 Original-Received: from localhost ([127.0.0.1]:45211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otSjQ-0001It-TQ for submit@debbugs.gnu.org; Fri, 11 Nov 2022 07:02:01 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otSjO-0001IL-5E for 58790@debbugs.gnu.org; Fri, 11 Nov 2022 07:01:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otSjI-0001mt-Bn; Fri, 11 Nov 2022 07:01:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=8nKYxdZSM9YjkKT6PhNtGJc+TMz7Zqlm/BLlUPzKoAo=; b=U4UouVqCbJS31Pxqqx6j gpdpmnWPVmJ4SMzQ4eQWDgxEePO9e8b4jX3zG2ZJmISReLwwZ0Y0v/WZ96Vxyt2+VbeqS+6vUnYLr yd22iC/JiXfb6Xxc9sjR9oz1Enuoapc2pMBXDBS7Kd9SvKVX7CRVo57oJ9pQTJ6zcV50V2J7UOBRU KptF2irGZCAHXAIXLyobxLNB/mHb2f0eDcbZKDGKbGx4nWg6wtVm50UU+gX5WiaVLyDmMieSUPKOe fCtWqKkAjbHtkhTkYHkvHICnQDA0ICYjQgYYRRUfIbFipYF8xtXqog5FXFzWzzwMo+QA83R7KC2/i hYcqvcya18YrMA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otSjH-0006Qy-Q4; Fri, 11 Nov 2022 07:01:52 -0500 In-Reply-To: <87sfip7rkt.fsf@gmail.com> (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Fri, 11 Nov 2022 09:45:06 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247580 Archived-At: > From: João Távora > Cc: danny@dfreeman.email, 58790@debbugs.gnu.org, > felician.nemeth@gmail.com, stefankangas@gmail.com, dgutov@yandex.ru > Date: Fri, 11 Nov 2022 09:45:06 +0000 > > >But future Emacs developers and maintainers might > > not have such insight, and I'm trying to represent them. This is part > > of my job and my responsibility. And since comments can never > > adversely affect code, I see no reason for you to object. > > Comments are not a 0-cost thing, obviously They can hamper readability, > they contribute e.g. to a small function no longer fitting in one > screen. They present a maintenance burden too and a source of > duplication. IME, these costs, while real, are dwarfed by the costs of making bad changes due to misunderstanding of why the code does what it does. And if I'm asking a contributor to add comments explaining why the code does what it does, it's usually because I didn't understand that by just looking at the code. And if I don't immediately understand that, there arew good chances quite a few others won't. > These are their drawbacks, but they have many many > advantages too, of course. You'll see me using comments very often. So we are in agreement?