From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59333: [PATCH] Define macro dlet* Date: Thu, 17 Nov 2022 09:25:00 +0200 Message-ID: <83leoadovn.fsf@gnu.org> References: <0e8ca5ce-a413-0dd0-c62e-647d19953a3b@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22608"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59333@debbugs.gnu.org To: daanturo , Stefan Monnier , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 17 08:26:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ovZI9-0005bX-VY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Nov 2022 08:26:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovZHg-00040x-Sn; Thu, 17 Nov 2022 02:26:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovZHe-000402-Uq for bug-gnu-emacs@gnu.org; Thu, 17 Nov 2022 02:26:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovZHe-0005gc-KC for bug-gnu-emacs@gnu.org; Thu, 17 Nov 2022 02:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ovZHe-0007V9-4v for bug-gnu-emacs@gnu.org; Thu, 17 Nov 2022 02:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Nov 2022 07:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59333 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59333-submit@debbugs.gnu.org id=B59333.166866991028777 (code B ref 59333); Thu, 17 Nov 2022 07:26:02 +0000 Original-Received: (at 59333) by debbugs.gnu.org; 17 Nov 2022 07:25:10 +0000 Original-Received: from localhost ([127.0.0.1]:58957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovZGo-0007U5-8C for submit@debbugs.gnu.org; Thu, 17 Nov 2022 02:25:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42114) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovZGl-0007Tp-Ex for 59333@debbugs.gnu.org; Thu, 17 Nov 2022 02:25:09 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovZGg-0005JP-0z; Thu, 17 Nov 2022 02:25:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=e+3tTkiyJauomt3HwymlSscKv6eVqOrAG9inEu7x27Q=; b=hlOlOnZzbXJPab6YTyZ7 xD3UEX7/cjgoLh52WoYoBqVK4UYVMKIP7GF6JDBAf/2Z0oTrcS+KYpP16Hdt62ZWkrGG7fZ9xhrlH yNoEjnTlB8uCGWyWyj17KcwUHUvImbjIcqKwEjxPuXWmPFWZyLO90u/ppmPpggkdtoQ94XH7ZJzEX GTeLieivQKaKnfoiJ4wa9YLcEdIrSC7OYknTUHI8LzVV0PuTP8J9tCsv39UvpsOUBDTF6Z39Jw02e lpKU9vqIxESdFAC9Kn3J0mG6guJlaCHStYOxNMXrk5GyIsAqFrS14G5p8q+R+3J3nfGxVUmjsP/jP 1FyxwIZ3hJl2rw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovZGf-0002AH-7t; Thu, 17 Nov 2022 02:25:01 -0500 In-Reply-To: <0e8ca5ce-a413-0dd0-c62e-647d19953a3b@gmail.com> (message from daanturo on Thu, 17 Nov 2022 14:13:35 +0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248094 Archived-At: > Date: Thu, 17 Nov 2022 14:13:35 +0700 > From: daanturo > > The dlet breakage comes as much surprise to me. There's not even a > single entry in NEWS that mentions it. dlet was new in Emacs 28, and the change you mention was done before Emacs 28 was released. So NEWS just mentions the introduction of dlet, and that is enough. > I would rather prefer b72f88518b89560accf740a4548368863e6238e0 be > reverted, though. But maybe that's fine if the majority of maintainers > agree with that change. But please mention similar breakages more > universally. I can only understand the breakage if someone picked up dlet as originally implemented on master, before Emacs 28 was released. In that case, it's the risk people take when they follow the development code too closely. As for the patch, I'd like to hear opinions about the need for dlet*. Thanks.