From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59381: Should xref--marker-ring be per-window? Date: Sat, 19 Nov 2022 21:53:26 +0200 Message-ID: <83leo67mbt.fsf@gnu.org> References: <86leo6ai85.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24114"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ackerleytng@gmail.com, 59381@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 19 20:54:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owTuu-0006AX-Rp for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Nov 2022 20:54:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owTue-0007Cr-4X; Sat, 19 Nov 2022 14:54:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owTuc-0007Cf-QD for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2022 14:54:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owTuc-0007bP-G4 for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2022 14:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owTuc-0007L7-7s for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2022 14:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Nov 2022 19:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59381 X-GNU-PR-Package: emacs Original-Received: via spool by 59381-submit@debbugs.gnu.org id=B59381.166888761028177 (code B ref 59381); Sat, 19 Nov 2022 19:54:02 +0000 Original-Received: (at 59381) by debbugs.gnu.org; 19 Nov 2022 19:53:30 +0000 Original-Received: from localhost ([127.0.0.1]:41489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owTu6-0007KP-A0 for submit@debbugs.gnu.org; Sat, 19 Nov 2022 14:53:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owTu2-0007KA-KV for 59381@debbugs.gnu.org; Sat, 19 Nov 2022 14:53:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owTtw-0007XR-TL; Sat, 19 Nov 2022 14:53:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ysWVTuCdsHDAspWzM47Xcuo8DnAKPW0hhvyNvuxPQwg=; b=kua8nipWnQg+ 8TWKAOgX4J13DY+eGm/HtAfuLGFwgG8F8d3eBxXIK8pNvlWigySvkMStpmKGs/YQx6H/KyoS4d8Tc hXLY8DymIeVBAoNVfaZAGSztkyJ+EbCAbyxwd4uHHAnl4MO/pVamDTREv5wkhMnMU4J94qRPskkgR x8VHOduMIvZ73nS0p3j5nj1vBlByrDfr4AB/BfR3eFfJcGDysRGTgkJxyB3BlwCo7WcLv7YJWHf1v 6FH2B+JwieZIV4H32j4vHnDdduHH8Z/FSxx9ex/R2vXxeUz18SbaSyj9WQwDty0d4Mg4GMixxxJXE 4u8Z1NiMkShtduONTlSdhw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owTtw-0008Q9-3m; Sat, 19 Nov 2022 14:53:20 -0500 In-Reply-To: <86leo6ai85.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 19 Nov 2022 20:53:46 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248375 Archived-At: > Cc: 59381@debbugs.gnu.org > From: Juri Linkov > Date: Sat, 19 Nov 2022 20:53:46 +0200 > > > While using xref (xref-find-definitions and xref-find-references, etc) > > in separate windows, I hit M-, to pop the marker stack expecting that > > each window should have a separate stack. > > > > However, it seems that the entire emacs instance shares a single > > xref--marker ring. > > > > Could we have separate xref--marker-rings per window, or some > > configuration option to enable that? > > Ideally, making an existing variable window-local should be as easy > as making it buffer-local, e.g.: > > (make-variable-buffer-local 'xref--history) > -> > (make-variable-window-local 'xref--history) > > But we are not here so far. I don't think it's that simple. Windows are much more ephemeral than buffers; for example, "C-x 2" followed by "C-x 1" or "C-x 0" deletes one of the windows. What do we want to happen with the "window-local" xref stack in that case? My guess is that the OP wanted to have control on when M-. pushes locations to the last used stack or begin a new stack. Because only the user knows when M-. begins a new series of searches. So I think it is better to offer a separate command for exercising just such control.