From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60143: 29.0.60; command `undo-redo` don't restore cursor position Date: Sun, 18 Dec 2022 13:03:43 +0200 Message-ID: <83len5ezxs.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16527"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60143@debbugs.gnu.org To: yinz Liu , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 18 12:04:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6rSp-00046S-L6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Dec 2022 12:04:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6rSg-0003fZ-5G; Sun, 18 Dec 2022 06:04:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6rSd-0003fH-31 for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 06:04:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6rSc-0001ci-Bl for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 06:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p6rSb-0007Or-Pm for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 06:04:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Dec 2022 11:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60143 X-GNU-PR-Package: emacs Original-Received: via spool by 60143-submit@debbugs.gnu.org id=B60143.167136142528437 (code B ref 60143); Sun, 18 Dec 2022 11:04:01 +0000 Original-Received: (at 60143) by debbugs.gnu.org; 18 Dec 2022 11:03:45 +0000 Original-Received: from localhost ([127.0.0.1]:33296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6rSL-0007Ob-HK for submit@debbugs.gnu.org; Sun, 18 Dec 2022 06:03:45 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6rSK-0007OP-BJ for 60143@debbugs.gnu.org; Sun, 18 Dec 2022 06:03:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6rSD-0001aS-P8; Sun, 18 Dec 2022 06:03:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5RyBX1uB7+1k/qV/duFGeGilXLus2aM33lmcxUpaVlo=; b=rmCes6QiCPGK ilfTU/2bT/DDcaeJjKz4Y9HbZw2FS+XvPPX33ouBsGbtL9o2coxClk8ASZ+QbOy8FkWk3oCKKpTrI X9uQqc7iYIVQUCrN7qRRe8jbxKeIQsBYj+QRx8h5b8c07wXjWsPmXU+gvkFHLnYUQ6n7wqppOlZ9L o7gvzaNYn5IB4s6F7t/DuEJb7m+dScB/K1gjAS92Apw5W4HYCe66Nt31ogtFfdL8UcEL8Baf6tgPt +oiwJZh0fsc6OhVAwTPUCAIpUFkSeeWcwrsCSqkJ5PnGdB36dGRhdwvNlozd6WHC4f5mt8Rl3hy3O +4vHKwHKKPzLupm6yXRc6g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6rSC-0005vI-F6; Sun, 18 Dec 2022 06:03:37 -0500 In-Reply-To: (message from yinz Liu on Sat, 17 Dec 2022 09:42:28 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251353 Archived-At: > From: yinz Liu > Date: Sat, 17 Dec 2022 09:42:28 +0800 > > aaaa ! bbbb @ cccc # > > 1. when cursor at position "#", call `undo', cursor jump to "@" > > 2. when cursor at position "@", call `undo-redo', text "cccc" restore, > but cursor still remain in "@", don't move to "#". > > my workaround fow now: > > in function primitive-undo : > > change L3624 to : `(goto-char (+ pos (length string)))` That code is there for almost 10 years, and before that the C implementation did the same. The way the code is written, viz.: (goto-char pos) (insert string) (goto-char pos)) it is clear that the second goto-char is on purpose, since if we delete it, we get the effect that you want; no need to goto anywhere else, because 'insert' leaves point after the inserted text. So I very much hesitate to change this. Stefan, any comments? do you happen to know why we return point to before the insertion?