From: Eli Zaretskii <eliz@gnu.org>
To: Jared Finder <jared@finder.org>
Cc: git@vladimir.panteleev.md, 61022-done@debbugs.gnu.org
Subject: bug#61022: 28.2.50; Mouse tracking of high coordinates not working in rxvt-unicode
Date: Thu, 26 Jan 2023 10:57:10 +0200 [thread overview]
Message-ID: <83lelpekrd.fsf@gnu.org> (raw)
In-Reply-To: <9e731b2056f75065a6b603aa80903400@finder.org> (message from Jared Finder on Tue, 24 Jan 2023 21:09:03 -0800)
> Date: Tue, 24 Jan 2023 21:09:03 -0800
> From: Jared Finder <jared@finder.org>
> Cc: git@vladimir.panteleev.md, 61022@debbugs.gnu.org
>
> On 2023-01-24 4:24 am, Eli Zaretskii wrote:
> >> - (read-char nil nil 0.1))
> >> + ;; Read a character with input method conversion enabled
> >> + ;; but no conversion to force read-char to decode UTF-8
> >> + ;; byte sequences.
> >> + (let ((input-method-function nil))
> >> + (read-char nil t 0.1)))
> >>
> >> This way we don't apply an actual input method conversion to
> >> characters.
> >> For example, without this additional change, if the 'british input
> >> method was active, the # ==> £ conversion would
> >> happen, causing mouse events with X=2 to instead have X=131.
> >
> > OK, but shouldn't we also use INHERIT-INPUT-METHOD = t in the call to
> > read-char only when xterm-mouse-utf-8 option is set? Otherwise, we
> > rely on read-char to not perform any conversions, but why rely on that
> > if we already know we don't want any conversions in that case? Using
> > nil when xterm-mouse-utf-8 is unset sounds like a more future-proof
> > change, no?
>
> I think that's not just future-proof, it's more correct.
Thanks. So I've installed such a change on the emacs-29 branch, and
I'm closing this bug.
prev parent reply other threads:[~2023-01-26 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-22 19:36 bug#61022: 28.2.50; Mouse tracking of high coordinates not working in rxvt-unicode git
2023-01-23 13:15 ` Eli Zaretskii
2023-01-24 6:56 ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-24 12:24 ` Eli Zaretskii
2023-01-25 5:09 ` Jared Finder via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-26 8:57 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lelpekrd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61022-done@debbugs.gnu.org \
--cc=git@vladimir.panteleev.md \
--cc=jared@finder.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).