From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Date: Sat, 28 Jan 2023 09:23:10 +0200 Message-ID: <83lelnazs1.fsf@gnu.org> References: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> <83o7qjbu0l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24590"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 61104@debbugs.gnu.org, theo@thornhill.no To: jostein@kjonigsen.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 28 08:24:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLfZR-0006EY-Ax for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Jan 2023 08:24:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLfZD-0005ha-MK; Sat, 28 Jan 2023 02:24:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLfZC-0005h7-Jh for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2023 02:24:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLfZC-0000xV-Bz for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2023 02:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pLfZB-0007B2-Rv for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2023 02:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jan 2023 07:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs Original-Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.167489061627557 (code B ref 61104); Sat, 28 Jan 2023 07:24:01 +0000 Original-Received: (at 61104) by debbugs.gnu.org; 28 Jan 2023 07:23:36 +0000 Original-Received: from localhost ([127.0.0.1]:39424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLfYm-0007AP-Dj for submit@debbugs.gnu.org; Sat, 28 Jan 2023 02:23:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLfYh-0007A8-4t for 61104@debbugs.gnu.org; Sat, 28 Jan 2023 02:23:34 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLfYb-0000s4-4J; Sat, 28 Jan 2023 02:23:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=omsAFMicTH8xBPSK8ZhRG/2puwkSJcUo9h/IZCJkVeo=; b=IwVOPgBkx6ziihvflYH0 EX415qwzQdj8yaRZXigT8/RtD9OyD1Geb+/89sy2K8GXS1SyiRVXjXkLRyQyZuoUKZBAyp6xZckVF lZUfmKoDuyBI36y8nODzpo1Cxv4/eIO30K7IydlgQnRA93VduwR4OpHKEDxrasRb0FHVvoHGxlKlA S2GiUly0smFqzBdL80Dqrur86MF6TIJQ3eerPAoXE35z1WmURJnKSsE+tiIGSaeNx2KLfh1I9g1Ed NhYL0k+CyZbDOhPxgSzIbzr4U/gQU6GrtGztr/8IZDJWlnmCmq5kG+u4YfCuEsrxxE8X8fVoyYl19 s5mqOpLynjukVg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLfYY-0003s0-R1; Sat, 28 Jan 2023 02:23:24 -0500 In-Reply-To: (message from Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= on Fri, 27 Jan 2023 21:52:24 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254290 Archived-At: > Date: Fri, 27 Jan 2023 21:52:24 +0100 > Cc: 61104@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no > From: Jostein Kjønigsen > > On 1/27/23 21:30, Eli Zaretskii wrote: > > > > Why isn't this part of compilation-error-regexp-alist-alist? > > That is obviously what I think we should do. > We already have good and tested matcher expressions for this. > > I was just uncertain about what the conventional way of adding those > expressions to Emacs: > > - adding it directly in the relevant major-mode's source-file, to > improve code-locality? I don't think doing this in the major-mode file will improve locality, because we have compilation-minor-mode, which should be able to do its thing even if the relevant major mode is not yet loaded. > - adding it in compile.el, to improve ability to oversee all > expressions, and be able to optimize those? > > I see csharp-mode.el has the expressions added directly there. Should I > go about preparing patches doing > the same for typescript-ts-mode too? I don't see why not.