From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56682: feature/improved-locked-narrowing 9dee6df39c: Reworked locked narrowing. Date: Tue, 14 Feb 2023 18:55:29 +0200 Message-ID: <83lel0chku.fsf@gnu.org> References: <166939872890.18950.12581667269687468681@vcs2.savannah.gnu.org> <83eds0ksev.fsf@gnu.org> <8aadf0ddd54c85c8144a@heytings.org> <831qnhg3d9.fsf@gnu.org> <9757fbea37611e9c44b9@heytings.org> <83cz6yacxt.fsf@gnu.org> <6943e04e30e5a02a52e6@heytings.org> <838rhk5fy1.fsf@gnu.org> <6943e04e30a40824e107@heytings.org> <83k0143q37.fsf@gnu.org> <94821a0ef100102ac9e0@heytings.org> <83bkmdz04y.fsf@gnu.org> <43562d4dd9dffd81938f@heytings.org> <83357ozhx0.fsf@gnu.org> <83wn4zurit.fsf@gnu.org> <83bkmaueib.fsf@gnu.org> <83357fnwyy.fsf@gnu.org> <83ttzsk6v4.fsf@gnu.org> <83wn4le8s3.fsf@gnu.org> <0f053182b02103503c26@heytings.org> <83pmaccnz7.fsf@gnu.org> <0f053182b04357300cb1@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10584"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca, akrl@sdf.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 14 17:56:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRybC-0002Th-Pu for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Feb 2023 17:56:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRyb7-0000md-9I; Tue, 14 Feb 2023 11:56:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRyb5-0000kg-5U for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 11:56:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRyb4-0004AE-SZ for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 11:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pRyb4-00075Y-HS for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 11:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Feb 2023 16:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.167639376027241 (code B ref 56682); Tue, 14 Feb 2023 16:56:02 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 14 Feb 2023 16:56:00 +0000 Original-Received: from localhost ([127.0.0.1]:56842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRyb2-00075I-C8 for submit@debbugs.gnu.org; Tue, 14 Feb 2023 11:56:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRyb0-000753-2z for 56682@debbugs.gnu.org; Tue, 14 Feb 2023 11:55:58 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRyat-00049N-48; Tue, 14 Feb 2023 11:55:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9O6aKqlIxZgdI1jChDXuyKJSqvakJfKxoXvG/yqUeDA=; b=qksrNBxi2Sgr bKlDNwwc1SgqxANlqGGbXVMMEZBjqUNF9B3tCZGAH/imFls0GMg87P8SuGpuAgs8BJkAXMJkb1oWG zHm6AXBrrYAKw97hNCezSuYlDNVebkVMmTOlApLJX++2IrEHfRmaTqt1dM0l77PHN1B3AILO3QoqN UH12+btDQOF7C8+oqB9/RpQUk4DNr2TxDMNQo6dz4Gya09xL1KeecIp0qKpdxsz/TRpJ1AnS8Hric z1MoJBrIXhXuyyvB722IaKM5cPgCRumcGGoK9SUqgOIesAJLP+dxQmaBwvwRq0m3BlbAKZFZ7jGOT pcnVALSOYI87LXLeB2QBwg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRyas-0004Nw-Jz; Tue, 14 Feb 2023 11:55:50 -0500 In-Reply-To: <0f053182b04357300cb1@heytings.org> (message from Gregory Heytings on Tue, 14 Feb 2023 14:59:22 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255614 Archived-At: > Date: Tue, 14 Feb 2023 14:59:22 +0000 > From: Gregory Heytings > cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca, akrl@sdf.org > > > >> 1. There are three places (indent.c:line_number_display_width, > >> xdisp.c:display_count_lines_logically, fileio.c:write_region) where we > >> currently use > >> > >> record_unwind_protect (save_restriction_restore, save_restriction_save ()); > >> Fwiden (); > > > > I'm not sure these should be subject to locked narrowing. They don't > > present performance problems with very long lines, AFAIK. > > > >> 2. In another place (process.c:Finternal_default_process_filter) we > >> currently have: > >> > >> /* If the output marker is outside of the visible region, save > >> the restriction and widen. */ > >> if (! (BEGV <= PT && PT <= ZV)) > >> Fwiden (); > >> > >> (without the "save the restriction" mentioned in the comment). > > > > This should be fixed to use unwind-protect of some kind, I think, and > > that's orthogonal to locked narrowing. > > > >> 3. Also, in Ferase_buffer, we do Fwiden to "delete the entire contents > >> of the current buffer". > >> > >> These five places probably need to be adapted to handle labeled > >> narrowings correctly. If you agree with that, I'll write a patch to > >> that effect. > > > > I'm not sure what you mean by "adapt to". Please tell more. > > > > Fwiden in the functions above (which are AFAICS the only places in Emacs > where Fwiden is called) is not prepared to the possibility of them being > called inside a labeled narrowing, either one installed by the long lines > code, or another one. Basically we need to use a variant of > reset_outermost_narrowings (for the current buffer only) where we use > > record_unwind_protect (save_restriction_restore, save_restriction_save ()); Ah, okay. Please do, and thanks.