From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62429: 30.0.50; Add jsx faces to typescript-ts-mode Date: Sat, 25 Mar 2023 15:30:37 +0300 Message-ID: <83lejlc8sy.fsf@gnu.org> References: <79CDDA5E-421D-4760-B744-F0C661118711@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38687"; mail-complaints-to="usenet@ciao.gmane.io" Cc: theo@thornhill.no, 62429@debbugs.gnu.org To: Yuan Fu , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 25 13:31:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pg33J-0009iI-VJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Mar 2023 13:31:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pg333-0000qa-Eg; Sat, 25 Mar 2023 08:31:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg332-0000qO-14 for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 08:31:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pg331-00069c-Ne for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 08:31:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pg330-000532-GH for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 08:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 12:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62429 X-GNU-PR-Package: emacs Original-Received: via spool by 62429-submit@debbugs.gnu.org id=B62429.167974745119377 (code B ref 62429); Sat, 25 Mar 2023 12:31:02 +0000 Original-Received: (at 62429) by debbugs.gnu.org; 25 Mar 2023 12:30:51 +0000 Original-Received: from localhost ([127.0.0.1]:42039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg32p-00052S-A3 for submit@debbugs.gnu.org; Sat, 25 Mar 2023 08:30:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg32n-00052D-Ma for 62429@debbugs.gnu.org; Sat, 25 Mar 2023 08:30:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg32f-00062w-Jx; Sat, 25 Mar 2023 08:30:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jFAhZkCD7M7NHD0z6O6FWDSCChKCDpkQtxFatsv9Pvk=; b=dPYWHPvIBfPa jrfcHcwlgzJOy3NUNY4fibWXm90asRWyPG21RL0YUXdCjmFeB2XzjedJVdIX7eWZkz+4U+mBhxrIA ak1dLs6aMRmmnYtYAkOe1kcSva4oMttDIMHSxnSvz5c/fFF0IIGsgW8me5DhUh4f5Gm+73Xa/fKSj bBpzYP8xgglJLkABhIG4D0v3694dvzzznPodV1t6kdLygQ6JhgtqWKlvUTfbBc/YG4SQMqqBwaTYS WVdog2PoaNQOXaWytUGJI0CaTWX4kwXEoH0C5LYVf0E9/sp81kYFUdoedTcZ8GQx9KsauzuZTZ+Gd ORx4BB68Gvl2EygwXzNbyg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg32f-0002hk-1n; Sat, 25 Mar 2023 08:30:41 -0400 In-Reply-To: <79CDDA5E-421D-4760-B744-F0C661118711@gmail.com> (message from Yuan Fu on Fri, 24 Mar 2023 16:49:35 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258553 Archived-At: > Cc: theo@thornhill.no > From: Yuan Fu > Date: Fri, 24 Mar 2023 16:49:35 -0700 > > Hey Theo, I want to add separate faces for JSX tags and attributes. > Otherwise users will be in a world of pain if they want to use different > fontification for JSX tag and funcall, and JSX attribute and constant. WDYT? We never had any mode-specific faces for font-lock, AFAIK. Why is this case different? Why not use one of the existing font-lock faces, or even add new ones (but not specific to JSX)? (Adding Stefan.)