From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63731: [PATCH] Support Emoji Variation Sequence 16 (FE0F) where appropriate Date: Fri, 26 May 2023 18:52:22 +0300 Message-ID: <83lehbjdjd.fsf@gnu.org> References: <87a5xrzsph.fsf@stebalien.com> <83pm6nlhll.fsf@gnu.org> <87v8gfmqyt.fsf@gmail.com> <83ilcflbua.fsf@gnu.org> <87mt1rmjjg.fsf@gmail.com> <83v8gfjnzj.fsf@gnu.org> <87edn3mbr3.fsf@gmail.com> <83mt1rjg69.fsf@gnu.org> <875y8fm7x7.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4669"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63731@debbugs.gnu.org, steven@stebalien.com To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 26 17:52:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2Zjp-0000zW-5i for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 May 2023 17:52:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2Zjc-0003Hd-Ef; Fri, 26 May 2023 11:52:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2ZjX-0003HM-TK for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 11:52:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q2ZjW-0007Qs-K9 for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 11:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q2ZjW-00088z-FO for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 11:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 May 2023 15:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63731-submit@debbugs.gnu.org id=B63731.168511632031297 (code B ref 63731); Fri, 26 May 2023 15:52:02 +0000 Original-Received: (at 63731) by debbugs.gnu.org; 26 May 2023 15:52:00 +0000 Original-Received: from localhost ([127.0.0.1]:50615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2ZjU-00088j-H1 for submit@debbugs.gnu.org; Fri, 26 May 2023 11:52:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2ZjS-000889-ID for 63731@debbugs.gnu.org; Fri, 26 May 2023 11:51:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2ZjN-0007PK-5R; Fri, 26 May 2023 11:51:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=+ibQ7ORUGTeE2ujn1igNJ63mJQ7LUZYOCCa35671ze4=; b=LsCCFcDsESKKQ19KWILQ p7YlGzuDqGgq/1uwfPEb1IhU5BuQYMmtqYwQCcxh6IlmvU/3aamelDe1kJ5T9fkSJsC1NmBL9FfaB sRD9cIDJyvPfI5iHMIJv3oCE3T3g/oLRt0yCtcKBN6I5G3hs45u9XlssRzZFdKyo2yWKvTNPlukya i1vWEVsYnf5ykinhfCQoxllP0klbMGJxXvdSzHfsG/VBBgOsFxviwTijKYKH0BGoQ5hbUVNkEVn/P mGgk4rYxcRLefOjMnxNeTl5JJ3jdTIitJmD1Ju1R0CraGyFIUitBD9i+45llVfI2fISyyzOG25jrj Fb8BgdJUoutIPw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2ZjL-00025t-Ln; Fri, 26 May 2023 11:51:51 -0400 In-Reply-To: <875y8fm7x7.fsf@gmail.com> (message from Robert Pluim on Fri, 26 May 2023 17:25:24 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262442 Archived-At: > From: Robert Pluim > Cc: steven@stebalien.com, 63731@debbugs.gnu.org > Date: Fri, 26 May 2023 17:25:24 +0200 > > Eli> Or are you saying that without including VS-15, CHAR+FE0E is not > Eli> displayed using its text representation? > > Not quite. If I donʼt have compose-gstring-for-graphic for VS-15, no > composition occurs for CHAR+FE0E. With my change youʼll get > composition, but itʼs still not 100% correct: CHAR+FE0E when CHAR is a > member of the emoji script will use emoji presentation, not text, but > the extra empty box will not show, so itʼs still an improvement. OK. And what about CHAR+FE0E when CHAR is not an Emoji? Anyway, I think you should install the patch on emacs-29, and we should then try to fix the text-representation bug with VS-15 on master. (I guess it requires a change to font.c or something?) > Eli> Did you test the proposed change with the admin/emoji-*.txt files, to > Eli> make sure they all still display OK? > > Yes. Iʼve also got a change that makes Emoji_Keycap_Sequence work, but > I think we can leave that for master. Depends on the solution, I guess. Isn't it just a change to the VS-16's entry in composition-function-table? Or maybe a change in the #x20e3's entry? (Did we discus the Emoji_Keycap_Sequence case before?)