unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Wang Diancheng <dianchengwang@gmail.com>
Cc: luangruo@yahoo.com, 64186@debbugs.gnu.org
Subject: bug#64186: Patch: Suppress deprecated '-gdb-set target-async' warning message in gdb-mi.el
Date: Thu, 29 Jun 2023 09:09:21 +0300	[thread overview]
Message-ID: <83leg2u7e6.fsf@gnu.org> (raw)
In-Reply-To: <CADmgXh6_0LsQfvLp-xAZckvmj_dD0k8KTcS1VjtHTgsht=dWGg@mail.gmail.com> (message from Wang Diancheng on Wed, 28 Jun 2023 11:51:39 +0800)

> From: Wang Diancheng <dianchengwang@gmail.com>
> Date: Wed, 28 Jun 2023 11:51:39 +0800
> Cc: luangruo@yahoo.com, 64186@debbugs.gnu.org
> 
> I did some hacks to make gdb-non-stop work, patch is attached. The
> patch try to set `gdb-non-stop` when target is running or at first
> stop. Sorry for rough patch. I'm new for elisp.

Thanks.  This looks about right to me, except that "run&" is not the
only command whose side effect is that the debuggee is running in the
background mode.  We also need to at least consider "attach&", I
think.  Maybe it would be useful to have a list of such commands, so
that we could expand it as needed in the future, because currently I
don't really understand what triggers background execution that causes
"-list-target-features" to report "async".  It sounds possible that
this happens only after the first command that ends with "&", in which
case we will need to add to the list all the commands mentioned in the
"Background Execution" node of the GDB manual.  This affects the test
below:

> +  ;; Set `gdb-non-stop` when `gdb-last-command` is a CLI background
> +  ;; `run` command e.g. r& or MI command `-exec-run`
> +  (when (or (string-match "&\s*$" gdb-last-command)
> +            (string-match "-exec-run" gdb-last-command))
> +    (gdb-try-check-target-async-support))

And I'm not sure I understand the idea behind this part:

> @@ -2722,6 +2744,9 @@ gdb-stopped
>  
>      ;; Print "(gdb)" to GUD console
>      (when gdb-first-done-or-error
> +      ;; If run target with CLI foreground command `run`, `target
> +      ;; async` can only be checked when target is stopped
> +      (gdb-try-check-target-async-support)
>        (setq gdb-filter-output (concat gdb-filter-output gdb-prompt-name)))

Can you elaborate?

Finally, please don't quote symbols `like this` in comments.  Our
conventions are to quote symbols 'like this' or `like this'.





  reply	other threads:[~2023-06-29  6:09 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20  2:21 bug#64186: Patch: Suppress deprecated '-gdb-set target-async' warning message in gdb-mi.el Wang Diancheng
2023-06-20  7:24 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-20  9:25   ` Wang Diancheng
2023-06-20  9:43     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-20 11:55     ` Eli Zaretskii
2023-06-21  6:49       ` Wang Diancheng
2023-06-21 13:12         ` Eli Zaretskii
2023-06-28  3:51           ` Wang Diancheng
2023-06-29  6:09             ` Eli Zaretskii [this message]
2023-06-30  7:08               ` Wang Diancheng
2023-07-06  7:10                 ` Eli Zaretskii
2023-04-25 19:18                   ` bug#63084: 30.0.50; gud: set breakpoint while program is running tatrics
2023-04-26  6:10                     ` Eli Zaretskii
2023-04-26  8:48                       ` TatriX
2023-04-26  9:44                         ` Eli Zaretskii
2023-04-26 11:19                           ` Eli Zaretskii
2023-04-26 11:49                             ` TatriX
2023-05-05  5:52                             ` Eli Zaretskii
2023-05-05  5:53                           ` Eli Zaretskii
2023-05-05  7:15                             ` TatriX
2023-05-06 11:43                               ` Eli Zaretskii
2023-05-27 21:22                                 ` TatriX
2023-05-28  5:28                                   ` Eli Zaretskii
2023-05-28 21:10                                     ` TatriX
2023-05-29 11:45                                       ` Eli Zaretskii
     [not found]                     ` <handler.63084.D64186.168862741914107.notifdone@debbugs.gnu.org>
2023-07-11  7:31                       ` bug#63084: closed (Re: bug#64186: Patch: Suppress deprecated '-gdb-set target-async' warning message in gdb-mi.el) TatriX
2023-07-11 12:24                         ` Eli Zaretskii
2023-07-11 15:30                           ` TatriX
2023-07-11 15:56                             ` Eli Zaretskii
2023-07-11 17:49                               ` TatriX
2023-07-13  6:26                                 ` Eli Zaretskii
2023-07-07  6:25                   ` bug#64186: Patch: Suppress deprecated '-gdb-set target-async' warning message in gdb-mi.el Wang Diancheng
2023-07-07  6:42                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83leg2u7e6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=64186@debbugs.gnu.org \
    --cc=dianchengwang@gmail.com \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).