From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log* Date: Wed, 05 Jul 2023 14:25:48 +0300 Message-ID: <83lefuk3b7.fsf@gnu.org> References: <87sfa44ixh.fsf@gmail.com> <83zg4ckki0.fsf@gnu.org> <87bkgr48qy.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39294"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64452@debbugs.gnu.org, acorallo@gnu.org, monnier@iro.umontreal.ca To: No Wayman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 05 13:26:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qH0eM-0009zk-JF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Jul 2023 13:26:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qH0e5-0000r5-BT; Wed, 05 Jul 2023 07:26:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH0e2-0000lm-Rk for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2023 07:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qH0e2-0007Dt-Ie for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2023 07:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qH0e1-0000PV-W9 for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2023 07:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jul 2023 11:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64452-submit@debbugs.gnu.org id=B64452.16885563591565 (code B ref 64452); Wed, 05 Jul 2023 11:26:01 +0000 Original-Received: (at 64452) by debbugs.gnu.org; 5 Jul 2023 11:25:59 +0000 Original-Received: from localhost ([127.0.0.1]:37214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH0dz-0000PB-3b for submit@debbugs.gnu.org; Wed, 05 Jul 2023 07:25:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH0dw-0000Ow-IR for 64452@debbugs.gnu.org; Wed, 05 Jul 2023 07:25:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH0dq-00077S-Sj; Wed, 05 Jul 2023 07:25:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7VuHEy0XO0XRX/Wu1TUeyc03lALUmpD0CnClnXIcPnI=; b=LB7s8CQSBqjd i6pbH+pHBev4UxLwbCcqxnBeKtDPKwuW8RsvayPXuOlyZ8elZU2H9xpugZG7VRTJP5aKXnusv4j9s Tyzom4CVeGQrOWJbObSu0ot/ZrwyxGMzSjZ2rgcsVzj8drHUYKMtRB3vBc7RzJsgl+c/pCYoMUGKw YE42Vt0WWv+yld6SYLOTdCzG3/9yx4DtyEcr+Tx8xVl+7sllKjA6RG/cywM8jEdVGSgJHZbqs7uPw 4jwSN3TBdR025N7kTcN3iIPMw7RrLJX4BUScEvzy+wKqkGheldX8mATgMdoVnByz9haetWYtrr3Je 9jeinLIrkorkKG6D4XqIvQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH0dq-0006Ar-86; Wed, 05 Jul 2023 07:25:50 -0400 In-Reply-To: <87bkgr48qy.fsf@gmail.com> (message from No Wayman on Tue, 04 Jul 2023 18:21:00 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264624 Archived-At: > From: No Wayman > Cc: Andrea Corallo , Stefan Monnier > , 64452@debbugs.gnu.org > Date: Tue, 04 Jul 2023 18:21:00 -0400 > > Eli Zaretskii writes: > > > Thanks, but why not elisp-compile-mode, like we do in > > *Compile-log* > > buffers for byte compilation? > > Works for me. Revision attached. > > diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el > index 22fb08e4688..5f42d10407f 100644 > --- a/lisp/emacs-lisp/comp.el > +++ b/lisp/emacs-lisp/comp.el > @@ -1133,7 +1133,8 @@ comp-log-to-buffer > (log-buffer > (or (get-buffer comp-log-buffer-name) > (with-current-buffer (get-buffer-create comp-log-buffer-name) > - (setf buffer-read-only t) > + (unless (derived-mode-p 'emacs-lisp-compilation-mode) > + (emacs-lisp-compilation-mode)) bytecomp.el uses (unless (derived-mode-p 'compilation-mode) (emacs-lisp-compilation-mode)) Isn't that better? Also, do we really need to do this twice in comp-run-async-workers? Andrea, any comments?