From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Sun, 16 Jul 2023 10:35:49 +0300 Message-ID: <83lefg9ulm.fsf@gnu.org> References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <83r0p9b3om.fsf@gnu.org> <83jzv1b152.fsf@gnu.org> <83a5vxas9k.fsf@gnu.org> <871qh8o12z.fsf@localhost> <83ttu49vhn.fsf@gnu.org> <87edl8mi2e.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14424"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, 64596@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 16 09:36:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKwIn-0003YC-Jm for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jul 2023 09:36:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKwIV-0003jO-VP; Sun, 16 Jul 2023 03:36:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKwIU-0003is-HZ for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 03:36:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKwIT-0002lb-OA for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 03:36:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKwIT-00079I-Jl for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 03:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jul 2023 07:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168949293427443 (code B ref 64596); Sun, 16 Jul 2023 07:36:01 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 16 Jul 2023 07:35:34 +0000 Original-Received: from localhost ([127.0.0.1]:46651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKwI2-00078Y-Fq for submit@debbugs.gnu.org; Sun, 16 Jul 2023 03:35:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKwI0-00078L-1c for 64596@debbugs.gnu.org; Sun, 16 Jul 2023 03:35:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKwHt-0002Fr-UG; Sun, 16 Jul 2023 03:35:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4H/v7A6ODAPkKJKE7picPeT18VayrG+PHsPtU0DVpMc=; b=ZLkaJqpdbpNU 4X7ObEBP4F5Y2k0VfmPlSaURlUdQcawcNAUvVh6VNtRPOFtnzeGp6JrAshi0pv5HoFdu/F4jMbGoP g0c7Vy3a3mqDSW88tLNoEi/fv8C7e6vT7w1EibKG48Uqt4OqseaMjEt19vXNeM8hbCW2DlaIetSEH p6SVS6O0wPcSpr3Xmd2tU82GUZW1c25hyLaawFdBG47gBGsLjqEMaQzf+5lZyaK1R/RBgct3AJGCs MMYAyCdlCYiaVfGFPs+G+qIGLXI0Oo35j3dBwDqrWo1+RgODkSwvevgFucQfOUPZPDg/itsEW3DOJ M/K6SBKBjDercLHZ0KIPjA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKwHt-0002rI-Cf; Sun, 16 Jul 2023 03:35:25 -0400 In-Reply-To: <87edl8mi2e.fsf@localhost> (message from Ihor Radchenko on Sun, 16 Jul 2023 07:28:09 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265289 Archived-At: > From: Ihor Radchenko > Cc: monnier@iro.umontreal.ca, 64596@debbugs.gnu.org > Date: Sun, 16 Jul 2023 07:28:09 +0000 > > Eli Zaretskii writes: > > >> BTW, is there any particular reason why windows_or_buffers_changed is > >> not a queue of windows/buffer to be re-displayed? > > > > Why do we need such a queue, when the redisplay flags of buffers and > > windows are supposed to tell us that already? > > To not loop over all the existing windows and frames in xdisp.c:506 > redisplay branch. Someone will have to demonstrate that this is worth our while. Testing a single boolean flag is not an expensive operation, while maintaining that queue also takes CPU. Also, some changes in a window can affect other windows on the same frame, for example if the window is resized. IOW, maybe it's a good idea and maybe it isn't, but it definitely doesn't affect the most expensive parts of redisplay.