From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64989: 29.1; Comment or uncomment lines in elisp-mode will show message in minibuffer Date: Tue, 01 Aug 2023 16:20:20 +0300 Message-ID: <83leeu292j.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16349"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64989@debbugs.gnu.org To: Eason Huang , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 01 15:21:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qQpJT-00045S-RY for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Aug 2023 15:21:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQpJB-0008Pu-9F; Tue, 01 Aug 2023 09:21:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQpJ8-0008PS-Gg for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 09:21:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQpJ8-00053s-98 for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 09:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qQpJ8-0004LO-3n for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2023 09:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2023 13:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64989 X-GNU-PR-Package: emacs Original-Received: via spool by 64989-submit@debbugs.gnu.org id=B64989.169089602616648 (code B ref 64989); Tue, 01 Aug 2023 13:21:02 +0000 Original-Received: (at 64989) by debbugs.gnu.org; 1 Aug 2023 13:20:26 +0000 Original-Received: from localhost ([127.0.0.1]:47402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQpIY-0004KS-EO for submit@debbugs.gnu.org; Tue, 01 Aug 2023 09:20:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQpIV-0004K7-0w for 64989@debbugs.gnu.org; Tue, 01 Aug 2023 09:20:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQpIO-0004nB-IF; Tue, 01 Aug 2023 09:20:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=N235XF7c2V7DoZAXg15u4f64bRYDC/IplueoOelMbTY=; b=Kh9jwmSmvrZq 6p1ijunN5erzgY9UlEiRtrAoXMDtVq8JY6RLUCJjVDP91Q7rOjsMUpHEeykMGEInfyaWCoOBJb2P3 TO5d33sWHSarAPgMGTXqgNiRszg22cDNFfEo+YqWmBW3BL1Ipva+crJYpfeA0Ms5welxH4CUsXE+T phBLFbXdxpP5eSZbK5mOJjutqdUI84IW0Q/4N+X/zOqomuJ9ZMnWemfip+j8JN0K9c4aDctjHFW4H oYkcc1RcUorM4ybVBPwOMCXU3L1AwKjgNrxXoV25AlBcywwn4cRhn72NNmz771kEndqzkTPBUT6Pb ae8zQa2iRwObG3w5eOEvgA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQpIO-0003OT-1F; Tue, 01 Aug 2023 09:20:16 -0400 In-Reply-To: (message from Eason Huang on Tue, 01 Aug 2023 19:13:59 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266450 Archived-At: > From: Eason Huang > Date: Tue, 01 Aug 2023 19:13:59 +0800 > > Hello Emacs, > > When update to the new released Emacs 29.1, I found that when comment or > uncomment lines in emacs-lisp-mode will show message in minibuffer as > below: > ``` > combine-change-calls: buffer-undo-list broken > ``` > Steps to reproduce: > 1. create a test.el file with any Elisp code. such as: > ``` > (message "Test") > ``` > 2. start emacs and open the test.el file with `emacs -Q ~/test.el` > 3. Use C-x C-; (comment-line) to comment the code in test.el > 4. Now you will see the message mentioned above. Thanks. Stefan, I think this is due to the commit below: | Author: Stefan Monnier | AuthorDate: Fri Jan 13 17:38:04 2023 -0500 | Commit: Stefan Monnier | CommitDate: Fri Jan 13 17:38:04 2023 -0500 | | * lisp/subr.el (combine-change-calls-1): Fix bug#60467 | | Don't stop at timestamps. Strip them for now, to be on the safe side. | Don't merge into `master` where we'll use a better fix. My "partial bisecting" indicates that the bug was introduced between Dec 31, 2022 and Jan 31, 2023, and the above is the only commit in-between that could matter. If indeed this is the culprit, can we perhaps backport the "better fix" from master to the emacs-29 branch?