From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65017: 29.1; Byte compiler interaction with cl-lib function objects, removes symbol-function Date: Fri, 04 Aug 2023 08:35:30 +0300 Message-ID: <83leerwesd.fsf@gnu.org> References: <8B08E514-B2D5-48F5-BA90-4F5A9492F8F9@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35580"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mattias.engdegard@gmail.com, 65017@debbugs.gnu.org, monnier@iro.umontreal.ca, eric.marsden@risk-engineering.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 04 07:36:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRnTx-00093K-8p for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Aug 2023 07:36:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRnTo-0006Fc-P8; Fri, 04 Aug 2023 01:36:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRnTm-0006FQ-Iw for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 01:36:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRnTm-0004r5-A1 for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 01:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRnTm-0006Cu-5H for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 01:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Aug 2023 05:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65017 X-GNU-PR-Package: emacs Original-Received: via spool by 65017-submit@debbugs.gnu.org id=B65017.169112733023818 (code B ref 65017); Fri, 04 Aug 2023 05:36:02 +0000 Original-Received: (at 65017) by debbugs.gnu.org; 4 Aug 2023 05:35:30 +0000 Original-Received: from localhost ([127.0.0.1]:53252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRnTG-0006C6-HF for submit@debbugs.gnu.org; Fri, 04 Aug 2023 01:35:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRnTF-0006Bj-9p for 65017@debbugs.gnu.org; Fri, 04 Aug 2023 01:35:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRnT7-0004bl-Su; Fri, 04 Aug 2023 01:35:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0p2UO8t6lX6YMbOxswbIXtr9Uo217K2VufP6wP7nzFI=; b=c7krAdVdwlK+ fVZqoCwSS6PE7LWfYeB+g+il0iS717JEs/+ZWhk1S65Vp09YvKwBXkew/GcOqhc57jRp8gqYbW7ZI NERFTnUowNmf7gajtLGAScwvZxxfwAnW7yJonkGVamvi3ebgmAi8Anx3noxc+oijOrp1LS3arNZeG v48aVFBBWkPMbkMWwYyCcNOUoOE/8YyEzpI0xwSAEDigPEXrB5qK9m5uty6UsEZRTDHOTayKlnI/p 6jbaBQwQs8NOLWbHorbd9IpDuJTTCwfQKrnu7lK20CJ3gm/QM1VSf7biUl67DaIINKltsI9atbIgt CP8xMyoVx4OKwVMF+RNwfQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRnT5-0003CD-Hr; Fri, 04 Aug 2023 01:35:20 -0400 In-Reply-To: (message from Alan Mackenzie on Thu, 3 Aug 2023 21:10:56 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266642 Archived-At: > Cc: acm@muc.de, 65017@debbugs.gnu.org, > Eric Marsden > Date: Thu, 3 Aug 2023 21:10:56 +0000 > From: Alan Mackenzie > > I think the cause is in internal_equal in src/fns.c, where the following > code appears: > > /* A symbol with position compares the contained symbol, and is > `equal' to the corresponding ordinary symbol. */ > if (SYMBOL_WITH_POS_P (o1)) > o1 = SYMBOL_WITH_POS_SYM (o1); > if (SYMBOL_WITH_POS_P (o2)) > o2 = SYMBOL_WITH_POS_SYM (o2); > > This piece of code converts symbols with positions to ordinary symbols > without first checking symbols-with-pos-enabled. I think this is the > bug. > > I will work on a patch to fix it (which shouldn't take long). Thanks, but when you have a solution in hand, please also check its effect on performance. AFAIR, this part was tuned for optimal performance, back when symbols with positions were introduced; it would be a pity to lose performance due to fixing this bug, if that can be avoided.