From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65206: 29.1; [windows][patch] build-deps-zips.py is broken and hard to maintain Date: Wed, 16 Aug 2023 15:08:44 +0300 Message-ID: <83leeb8a0j.fsf@gnu.org> References: <83msyzhvpz.fsf@gnu.org> <837cpw9uq6.fsf@gnu.org> <834jl09tvy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20684"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65206@debbugs.gnu.org To: Corwin Brust Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 16 14:09:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qWFLA-0005Ac-58 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Aug 2023 14:09:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWFKj-0004li-Rm; Wed, 16 Aug 2023 08:09:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWFKg-0004ks-E2 for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2023 08:09:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qWFKg-0001QR-59 for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2023 08:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qWFKf-0005A5-Ro for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2023 08:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Aug 2023 12:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65206-submit@debbugs.gnu.org id=B65206.169218772619809 (code B ref 65206); Wed, 16 Aug 2023 12:09:01 +0000 Original-Received: (at 65206) by debbugs.gnu.org; 16 Aug 2023 12:08:46 +0000 Original-Received: from localhost ([127.0.0.1]:39005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWFKP-00059R-R8 for submit@debbugs.gnu.org; Wed, 16 Aug 2023 08:08:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWFKN-000599-U9 for 65206@debbugs.gnu.org; Wed, 16 Aug 2023 08:08:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWFKI-0001ON-Hl; Wed, 16 Aug 2023 08:08:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=JSK8payd4uDf1J8IfIpDpJwro18743Gn3cB71SLQzrg=; b=qBUikWceDWAKW7sQXrJp OteeOsUMHf1/WU93kphI1+s/zdvDdgzMtrUx5ufMOPNqBM14/67Kf8ztlMqkJbRSFkVwCnGjEFLfx cPnwP7ZkiebXrkFQcM7QNVWemhwByDkgITF/4718hXYVk8IGzM2u4PnJm5/vZnQvJ2j06XDQs6F5T p0Js9fJFlfMPN19tit7I/QrIO56KF1v1e7vfjnmOxWRVhkHvDI10VgX1f+qHOL1JjGa7CGmy7n69Z IgSNPKC932R6eXnV69AlYG1wo1UlRvq1rEgS3d/aHRSrvmqLHNReS1FctQ29FJXZrCAaoRiAswUH+ DoF2BbaREHrXlg==; In-Reply-To: (message from Corwin Brust on Tue, 15 Aug 2023 20:23:44 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267576 Archived-At: > From: Corwin Brust > Date: Tue, 15 Aug 2023 20:23:44 -0500 > Cc: 65206@debbugs.gnu.org > > On Tue, Aug 15, 2023 at 11:01 AM Eli Zaretskii wrote: > > > > OK, so here's a suggestion which might improve that crucial part: scan > > the list in dynamic-library-alist, on lisp/term/w32-win.el. Every > > dependency that is loaded dynamically (i.e., Emacs is not linked > > against it when it is built) must be in that list. So when we add > > dependencies, we add them there. > > I looked at the variable. OT1H, it serves a very different use-case > ("what are valid DLL names for a given library?" in the run-time, vs > "what DLLs should be sent along with Emacs?" in the build-time). > This means that meaningful hackery would likely be needed to > contemplate removing the hard-coded list completely, or even that we > would not be able to device any means of parsing this and choosing the > correct sent among DLLs present on the build system, to include. I'm not sure I understand the reservation. That list mentions every single DLL that we know can be used for each optional feature. If a feature has more than one DLL listed, the first one is usually the most popular, and should be tried first. Given this, what problems do you envision with using that list? > Thus, if we are content to have the script detect, and error demanding > correction when out of sync wrt `dynamic-library-alist', I believe it > can be done. Moreover, IMO this will definitely help. Great, that's what I hoped to achieve: a way of verifying that your list of first-order dependencies is complete. > Does a "invokes Emacs now and errors out if stuff is missing" approach > sound right/good? I'm not sure I understand how would you force Emacs to "error out" when we are talking about optional dependencies. They are optional so that Emacs could run even if they are not present.