From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64735: 29.0.92; find invocations are ~15x slower because of ignores Date: Tue, 12 Sep 2023 14:39:24 +0300 Message-ID: <83ledbpqmr.fsf@gnu.org> References: <83sf9eub9d.fsf@gnu.org> <2d844a34-857d-3d59-b897-73372baac480@gutov.dev> <83bkg2tsu6.fsf@gnu.org> <83bd4246-ac41-90ec-1df3-02d0bd59ca44@gutov.dev> <834jlttv1p.fsf@gnu.org> <937c3b8e-7742-91b7-c2cf-4cadd0782f0c@gutov.dev> <83a5vlsanw.fsf@gnu.org> <69a98e2a-5816-d36b-9d04-8609291333cd@gutov.dev> <87351cs8no.fsf@localhost> <35163e56-607d-9c5b-e3e8-5d5b548b3cb7@gutov.dev> <878rb3m43b.fsf@localhost> <83v8e6lyi4.fsf@gnu.org> <35f8b664-0241-9f96-1aa0-20ca51b2d34c@gutov.dev> <59c30342-a7e0-d83b-a128-0faae4cbd633@gutov.dev> <83pm4bi6qa.fsf@gnu.org> <83bkfs2tw5.fsf@gnu.org> <18a0b4d8-32bd-3ecd-8db4-32608a1ebba7@gutov.dev> <83il8lxjcu.fsf@gnu.org> <2e21ec81-8e4f-4c02-ea15-43bd6da3daa7@gutov.dev> <8334zmtwwi.fsf@gnu.org> <83tts0rkh5.fsf@gnu.org> <14b26ff0-9d9b-3600-bf6e-133db4031622@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33333"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, sbaugh@janestreet.com, yantar92@posteo.net, 64735@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 12 13:56:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qg203-00075F-LJ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Sep 2023 13:56:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qg1lN-0003wm-4C; Tue, 12 Sep 2023 07:41:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qg1lL-0003rC-Ld for bug-gnu-emacs@gnu.org; Tue, 12 Sep 2023 07:40:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qg1lL-00031m-Cz for bug-gnu-emacs@gnu.org; Tue, 12 Sep 2023 07:40:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qg1lO-0007ZH-MA for bug-gnu-emacs@gnu.org; Tue, 12 Sep 2023 07:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Sep 2023 11:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64735 X-GNU-PR-Package: emacs Original-Received: via spool by 64735-submit@debbugs.gnu.org id=B64735.169451881629027 (code B ref 64735); Tue, 12 Sep 2023 11:41:02 +0000 Original-Received: (at 64735) by debbugs.gnu.org; 12 Sep 2023 11:40:16 +0000 Original-Received: from localhost ([127.0.0.1]:56326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qg1kV-0007Xu-9h for submit@debbugs.gnu.org; Tue, 12 Sep 2023 07:40:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qg1kQ-0007XG-9q for 64735@debbugs.gnu.org; Tue, 12 Sep 2023 07:40:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qg1k6-0002fT-AA; Tue, 12 Sep 2023 07:39:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wcFFnMb+m4sTdfLtKnVv9R8+ktdQFlm0Gd/TEQvajQM=; b=k9NmyED/BhFq 10y5eqsGvz+8VW0iC4mFvmqq1Xida7XpRQdq1rb9DS4X9mE/XtiWIt/Kp54OAJVkn5qIKrF/k/e02 lJB2OHKKZiZsI4f+HbCqE4vW1WMaWjLDPEADnbM24rqWqE7snLIR3BHaX9TvGPc2RiPuagc5bQ6Ir L2K3nA9L7LBjkOrv2dQx4las2wzaxpgCi5NOvimg7Q3SV8OKiuxCMmH30I6tohZLBghr1HEecoV/j +jZKzCJRAlo/z2bIEBLN5bC/5GRJzcZ2LlDgGKvtdLGjrizTRjfMcHAzs2Rq145JAY13wE0ExnM+x iTN5ZzX1DdSHfoJzjdA71g==; In-Reply-To: <14b26ff0-9d9b-3600-bf6e-133db4031622@gutov.dev> (message from Dmitry Gutov on Tue, 12 Sep 2023 02:06:50 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270157 Archived-At: > Date: Tue, 12 Sep 2023 02:06:50 +0300 > Cc: luangruo@yahoo.com, sbaugh@janestreet.com, yantar92@posteo.net, > 64735@debbugs.gnu.org > From: Dmitry Gutov > > > No, we don't wait until it's zero, we perform GC on the first > > opportunity that we _notice_ that it crossed zero. So examining how > > negative is the value of consing_until_gc when GC is actually > > performed could tell us whether we checked the threshold with high > > enough frequency, and comparing these values between different runs > > could tell us whether the shorter time spend in GC means really less > > garbage or less frequent checks for the need to GC. > > Good point, I'm attaching the same outputs with "last value of > consing_until_gc" added to every line. > > There are some pretty low values in the "read-process-output-max 409600" > part of the experiment, which probably means runtime staying in C > accumulating the output into the (now larger) buffer? Not sure. No, I think this means we really miss some GC opportunities, and we cons quite a lot more strings between GC cycles due to that. I guess this happens because we somehow cons many strings in code that doesn't call maybe_gc or something.