From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62677: Merge flyspell-mode with flyspell-prog-mode Date: Sun, 24 Sep 2023 18:41:35 +0300 Message-ID: <83lecv37f4.fsf@gnu.org> References: <87mt3mv5e9.fsf@web.de> <076460cb-f203-de49-c949-bdc213fd1965@gmail.com> <83y1n5r0i9.fsf@gnu.org> <83o7if35x5.fsf@gnu.org> <83bkef15rx.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4894"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, jporterbugs@gmail.com, 62677@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 24 17:42:57 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkRG4-00014u-QX for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Sep 2023 17:42:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkRFz-0005Os-Ss; Sun, 24 Sep 2023 11:42:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkRFy-0005OY-Od for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2023 11:42:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qkRFy-0007GD-GF for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2023 11:42:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qkRGA-000558-AQ for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2023 11:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Sep 2023 15:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62677 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy Original-Received: via spool by 62677-submit@debbugs.gnu.org id=B62677.169557014619473 (code B ref 62677); Sun, 24 Sep 2023 15:43:02 +0000 Original-Received: (at 62677) by debbugs.gnu.org; 24 Sep 2023 15:42:26 +0000 Original-Received: from localhost ([127.0.0.1]:43462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkRFa-000541-AM for submit@debbugs.gnu.org; Sun, 24 Sep 2023 11:42:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkRFY-00053o-T4 for 62677@debbugs.gnu.org; Sun, 24 Sep 2023 11:42:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkRFH-0007Cy-La; Sun, 24 Sep 2023 11:42:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bW4jVGlCFHEgMEvcvrlOy4w/zkfGX1kHkhm46TEjisQ=; b=kPpqLO/m+m7K Ek1lT5GR8DOf7oc9a3ecMJY8b9n9vREzviz/aaPEH57LpeM7g7/LglKD2JjUcsxh+wQPEFae7AM39 +Tf5kztIblt7mnmidVkEmOMImNcbBkZqnTGcVCHgOZX6PsY7zY397Dzf+Gg+mXzyCV3NG5L4VNovS Z7i718ti+EGqHA8dDqz+7rU4W3oVVK+qNIYjCxA4qFrfNTeNh5THwNaPHVnQd2NNqf1LMklmQLOjw elSoq/i9wvj28y19eG202E+6hmnUEVS2BLAmyesNGLnV2mo7X7gMfgn1w24b8YAEpfGAl/WqO4R7H zc7MoeYPnQuPjryw9U5QSw==; In-Reply-To: (message from Stefan Kangas on Sun, 24 Sep 2023 07:08:56 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271256 Archived-At: > From: Stefan Kangas > Date: Sun, 24 Sep 2023 07:08:56 -0700 > Cc: michael_heerdegen@web.de, jporterbugs@gmail.com, 62677@debbugs.gnu.org > > Eli Zaretskii writes: > > >> From: Stefan Kangas > >> Date: Wed, 6 Sep 2023 11:51:14 -0700 > >> Cc: jporterbugs@gmail.com, michael_heerdegen@web.de, 62677@debbugs.gnu.org > >> > >> Here's the plan I'd propose: Add a new defvar-local > >> `flyspell-use-prog-mode' or somesuch that major modes can set. Now, > >> when a user enables `flymake-mode' in a buffer where that variable is > >> non-nil, the extra stuff done in `flyspell-prog-mode' gets done too. > >> Then decide which built-in major modes that would benefit, and set that > >> variable in them. > > > > SGTM. > > > >> Would `prog-mode' be a candidate though, or do we expect any modes > >> inheriting from it to want the regular `flyspell-mode'? > > > > The former, I guess? > > Thanks. How does the attached patch look? Looks good in general, but why deprecate and de-document flyspell-prog-mode? I can easily envision a major mode that doesn't inherit from prog-mode, but still has defined syntax for comments and strings: why not let users invoke flyspell-prog-mode in those cases? Moreover, users might have customizations that reference flyspell-prog-mode, and I see no reason to annoy them with obsoletion warnings. IOW, we just made the users' lives easier by automatically activating flyspell-prog-mode when we know it's appropriate, we are not saying that what flyspell-prog-mode does is incorrect or suboptimal.