From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 66328-done@debbugs.gnu.org, stephen.berman@gmx.net
Subject: bug#66328: 29.1; Incompatible change to `completing-read' breaks existing code
Date: Wed, 04 Oct 2023 10:31:12 +0300 [thread overview]
Message-ID: <83leci6dz3.fsf@gnu.org> (raw)
In-Reply-To: <SJ0PR10MB548813C9FF0EA4C61CCCC839F3CBA@SJ0PR10MB5488.namprd10.prod.outlook.com> (message from Drew Adams on Wed, 4 Oct 2023 02:04:01 +0000)
> Cc: "66328@debbugs.gnu.org" <66328@debbugs.gnu.org>
> From: Drew Adams <drew.adams@oracle.com>
> Date: Wed, 4 Oct 2023 02:04:01 +0000
>
> > > How did the signature of `completing-read' get changed?
> > > I didn't notice any proposal or discussion about this
> > > in emacs-devel@gnu.org. Did I just miss it somehow?
> > >
> > > It used to be that _any_ REQUIRE-MATCH value that is
> > > not `t', nil, `confirm', or `confirm-after-completion'
> > > behaves like `t', except that type RET doesn't exit if
> > > what you type does non-null completion.
> > >
> > > That's no longer true if the value is a function!
> > > This completely changes the behavior of `completing-read'.
> > >
> > > Not happy with the result, and not happy with how the
> > > process - how this was done, if it wasn't discussed
> > > openly in emacs-devel.
> >
> > There was a short discussion, after the change was made, starting here:
> > https://urldefense.com/v3/__https://lists.gnu.org/archive/html/emacs-
> > devel/2022-
> > 06/msg00539.html__;!!ACWV5N9M2RV99hQ!Pi4vEIugzynWXlOXCj_8GVnUyeP_8Q9i9ysV
> > ZwoUAmd2dc4qwMRUMS8Ce9W_d_8GAlmYBaDccZg8x2-utGVJed4B$
>
> I see; thank you!
>
> Yes, very ugly. And no proposal or discussion;
> just Lars changing things. At least Stefan
> spoke up (though not about the basic breaking
> of compatibility) - after the fait accompli.
>
> I suppose I should have guessed it was something
> like that. Wish I'd have seen it at the time,
> and realized what the overall effect is.
>
> Really too bad.
>
> The justification given: "adding a new parameter
> for this use case seemed a bit overboard." So
> just break what that argument has always been
> about, and reuse it for something altogether
> different? Sigh.
I see no reason to revert that change, so I'm closing this bug.
next prev parent reply other threads:[~2023-10-04 7:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 22:11 bug#66328: 29.1; Incompatible change to `completing-read' breaks existing code Drew Adams
2023-10-03 23:25 ` Stephen Berman
2023-10-04 2:04 ` Drew Adams
2023-10-04 7:31 ` Eli Zaretskii [this message]
2023-10-04 7:23 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83leci6dz3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=66328-done@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).