From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66719: mark-defun doesn't like function literals / the need for treesit-mark-defun Date: Tue, 24 Oct 2023 13:56:39 +0300 Message-ID: <83lebsmgpk.fsf@gnu.org> References: <8734y1m4w8.fsf@honnef.co> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14976"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66719@debbugs.gnu.org To: Dominik Honnef Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 24 12:58:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qvF7D-0003es-2y for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Oct 2023 12:58:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qvF6V-000880-Mn; Tue, 24 Oct 2023 06:57:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvF6K-00085F-H9 for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2023 06:57:34 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qvF6K-00037l-42 for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2023 06:57:32 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qvF6n-0004Wf-J4 for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2023 06:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Oct 2023 10:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66719 X-GNU-PR-Package: emacs Original-Received: via spool by 66719-submit@debbugs.gnu.org id=B66719.169814503617333 (code B ref 66719); Tue, 24 Oct 2023 10:58:01 +0000 Original-Received: (at 66719) by debbugs.gnu.org; 24 Oct 2023 10:57:16 +0000 Original-Received: from localhost ([127.0.0.1]:53266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvF62-0004VU-Sf for submit@debbugs.gnu.org; Tue, 24 Oct 2023 06:57:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvF5z-0004VF-47 for 66719@debbugs.gnu.org; Tue, 24 Oct 2023 06:57:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvF5P-0002ua-2C; Tue, 24 Oct 2023 06:56:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sxJz4vZwTaQYrPribntwirAIvr2LzzjVkZ9E2dqtSaM=; b=NXZYG+ig0ytK HFis18BM4MOXwsUQwLw1OiID4BxYX/HBDx0POOoKP1apxUfW1eF2BRtMfx9SyxGkcf5C4qRG0aiWs xPi5UxJH2EDb/qrMbhAp6X66ZJ99seAHN8kehGod5240y6ukJtmwvRM7OUsZlpqip2MGgRn4cTHj+ iLHmQykcXjUnONG5T1m/jn+gNtGF8tmTsENUQho4EcIiC+qdmyFGIJI2nLoIwhi81lGTxMHGKzJcE x/ddRWG9LKiqo57gQRO9vM+sggALgnVmcH+e/UTsrJBoxC0D6g+d5Qb/+FfAG85F2uqdwCGxX8C7L RdxNklx4lGSJLkzZRgjoGA==; In-Reply-To: <8734y1m4w8.fsf@honnef.co> (message from Dominik Honnef on Mon, 23 Oct 2023 22:59:35 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273094 Archived-At: > From: Dominik Honnef > Date: Mon, 23 Oct 2023 22:59:35 +0200 > > treesit.el currently defines treesit-beginning-of-defun and > treesit-end-of-defun, and binds C-M-a and C-M-e to them in addition to > setting beginning-of-defun-function and end-of-defun-function. > > That way, C-M-a and C-M-e work well even for function literals, which do > not necessarily start and end on their own, dedicated lines. This > differs from beginning-of-defun, which always goes to the beginning > of the line. > > The problem is that there is no treesit-mark-defun, and mark-defun calls > beginning-of-defun, via beginning-of-defun-comments. mark-defun is defined for Lisp and Lisp-like languages, it is not a function that's supposed to support any major mode. If we want a PL-independent mark-defun function, we need first to refactor mark-defun to allow mode-specific behavior.