From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66470: 29.1; Provide Urdu input method Date: Sun, 29 Oct 2023 13:51:41 +0200 Message-ID: <83leblbq9e.fsf@gnu.org> References: <87pm1lm23l.fsf@zohomail.eu> <87lec9m12g.fsf@zohomail.eu> <837cnpshz2.fsf@gnu.org> <877cnp1ojf.fsf@zohomail.eu> <83zg0lqxtq.fsf@gnu.org> <8734yd1mfm.fsf@zohomail.eu> <83sf6dqt33.fsf@gnu.org> <87zg0bye19.fsf@zohomail.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2046"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66470@debbugs.gnu.org To: Rahguzar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 29 12:52:49 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qx4LZ-0000NH-Bl for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Oct 2023 12:52:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qx4LJ-0001FR-Vh; Sun, 29 Oct 2023 07:52:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qx4LF-0001FB-To for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 07:52:29 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qx4LF-0002GH-LU for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 07:52:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qx4Lm-0008RG-4v for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 07:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Oct 2023 11:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66470 X-GNU-PR-Package: emacs Original-Received: via spool by 66470-submit@debbugs.gnu.org id=B66470.169858035832402 (code B ref 66470); Sun, 29 Oct 2023 11:53:02 +0000 Original-Received: (at 66470) by debbugs.gnu.org; 29 Oct 2023 11:52:38 +0000 Original-Received: from localhost ([127.0.0.1]:40597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qx4LO-0008QX-BQ for submit@debbugs.gnu.org; Sun, 29 Oct 2023 07:52:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qx4LL-0008QH-QM for 66470@debbugs.gnu.org; Sun, 29 Oct 2023 07:52:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qx4Kj-0002CQ-Vw; Sun, 29 Oct 2023 07:51:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=9BqLh26/Epw/V1FjiOzHDDQJQ6R+hXZwflIsu4G2DH0=; b=dhvwxIek/8FE0kFekswz JBNe0xQT5kuwRocJmelnslwAf+OU9kTAYQYH+/64i4h5j/NQ4MWRFBfu7tElKlvw5xlFQynUGQS9p UHWV5xVy4/uEMIiZfuHF6GWFPFEKLuQDOdcCW1kDJo5X25NoYMKoADMC1l6paTF83b++ShKSsImPr 5mdipFZptgOIN9gWU2rGtVnqNsbo0llo+zcyw1Z7JLxo8aiZO6AWVGv7uGQQUTfhh/S2meG5Ll2tr VChhxWd2+rqINeMNlQSANJyuHOQPmX3jonJQQh9E6G6gX3neeyHN9tfUPywBlRp/vQW/9R9GyI6AT 7KdNjrXP/U0fUg==; In-Reply-To: <87zg0bye19.fsf@zohomail.eu> (message from Rahguzar on Sat, 21 Oct 2023 20:59:10 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273496 Archived-At: > From: Rahguzar > Cc: 66470@debbugs.gnu.org > Date: Sat, 21 Oct 2023 20:59:10 +0200 > > I have attached a new patch with this email containing 5 input methods. > 3 of them for Urdu and 1 each for Pashto and Sindhi. Two of Urdu input > methods correspond to the two keyboards at https://www.branah.com/urdu > and the Pashto and Sindhi input methods follow keyboard layouts from the > same page. Thanks. This lacks a ChangeLog-style commit log message (see CONTRIBUTE and "git log" for how we write those). > +;; Layout taken from https://www.branah.com/urdu > +(quail-define-package > + "urdu-keyboard" "Urdu" "اردو تختی" t ^^^^^^^^ Can you come up with a shorter mode-line indicator for this and other input methods? We usually use just 1 or 2 letters for it; you used something much longer. > +(defun pakistan--define-quail-rules (rules &optional prefix package) > + "Define the rules for an input method. Our style is to have the first sentence of a doc string be a summary of what the function does and also mention all the mandatory arguments. I would suggest something like Define rules for a Pakistan input method as determined by RULES. > +(defun pakistan--make-setter (&optional prefix package) > + "Retrun the setter function. ^^^^^^ Typo. > +The function add rules to PACKAGE with PREFIX." ^^^ "adds". > +(defun pakistan--set-numeral-translations (var val) > + "Add translations for digits. This should mention the arguments. > +(quail-define-package > + "urdu-custom" "Urdu" "اردو انفر۱دی" t > + "Intuitive and customizable transl input method for Urdu. > +By default this input method doesn't try to follow the common romanization of Urdu > +very closely. The reason for this is allow to for input efficiency. It works as > +follows: Please try not to use lines longer than 79 characters in doc strings. Thanks.