unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 68158@debbugs.gnu.org, joseph@breatheoutbreathe.in
Subject: bug#68158: isearch-wrap-pause 'no or 'no-ding breaks isearch-delete-char
Date: Thu, 04 Jan 2024 19:49:42 +0200	[thread overview]
Message-ID: <83le95vvih.fsf@gnu.org> (raw)
In-Reply-To: <86wmspnngh.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 04 Jan 2024 19:02:52 +0200)

> From: Juri Linkov <juri@linkov.net>
> Cc: Joseph Turner <joseph@breatheoutbreathe.in>,  68158@debbugs.gnu.org
> Date: Thu, 04 Jan 2024 19:02:52 +0200
> 
> >> C-s b a z
> >>
> >> ...then attempt to delete the non-matching "z" character with DEL.
> >>
> >> GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37,
> >> cairo version 1.16.0)
> >
> > Juri, could you please look into this?  It seems to be a regression in
> > Emacs 29.1 due to your changes in commit 7320a812e, to solve
> > bug#56535.  I guess we need to distinguish between self-inserting
> > characters and DEL?
> 
> This means that we need to preclude 'isearch-push-state' in 'isearch-repeat'
> from updating 'isearch-cmds'.
> 
> Should I push this patch to the emacs-29 branch?  It looks safe.

Yes, please.

Thanks.





  reply	other threads:[~2024-01-04 17:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-30 22:56 bug#68158: isearch-wrap-pause 'no or 'no-ding breaks isearch-delete-char Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-04 11:10 ` Eli Zaretskii
2024-01-04 17:02   ` Juri Linkov
2024-01-04 17:49     ` Eli Zaretskii [this message]
2024-01-05  7:41       ` Juri Linkov
2024-01-04 18:58     ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-05  7:42       ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83le95vvih.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=68158@debbugs.gnu.org \
    --cc=joseph@breatheoutbreathe.in \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).