bug#5493: 23.1.91; Visiting a versioned file while bzr is running signals an error

bug#5493: 23.1.91; Visiting a versioned file while bzr is running signals an error

[Eli Zaretskii]

On the command line, start some prolonged bzr command, like "log -n0".
While that is running, type this in the bzr-controlled tree:

  emacs -Q
  C-x C-f lisp/files.el

You will see this error message:

  Error: (error Running bzr status files.el...FAILED (status 3))

This happens because a running bzr command locks the `dirstate' file.
The .bzr.log file shows this:

  LockContention: Could not acquire lock "D:/gnu/bzr/emacs/trunk/.bzr/checkout/dirstate": (32, 'CreateFileW', 'The process cannot access the file because it is being used by another process.')

(This is not limited to MS-Windows, btw.)

The result of this is that the version of the file is not displayed on
the modeline, and the error message itself is annoying enough as well.

Bazaar docs says that "bzr info" can be used to show what locks are
open.  I couldn't get this to work (will ask on the Bazaar list), but
if it indeed works, then perhaps we could produce a more useful
message, and maybe even fire up a timer to "bzr status" the file
later, when the lock is relinquished.


In GNU Emacs 23.1.91.1 (i386-mingw-nt5.1.2600)
 of 2009-12-31 on HOME-C4E4A596F7
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  value of $XMODIFIERS: nil
  locale-coding-system: cp1255
  default enable-multibyte-characters: t

Major mode: Mail

Minor modes in effect:
  shell-dirtrack-mode: t
  flyspell-mode: t
  desktop-save-mode: t
  show-paren-mode: t
  display-time-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  temp-buffer-resize-mode: t
  line-number-mode: t
  abbrev-mode: t

Recent input:
h a n SPC 1 2 8 . SPC SPC J a s o n , SPC d o SPC y 
o u SPC a g r e e ? SPC SPC J u a n m a , SPC c a n 
SPC y o u SPC c h e c k SPC t h a t SPC r e m o v i 
n g SPC t h a t SPC d o e s SPC n o t SPC c a u s e 
SPC t r o u b l e SPC i n SPC y o u r SPC u s e - c 
a s e ? <return> <C-home> C-c C-s <switch-frame> <M-home> 
<C-end> <M-end> C-x C-s <help-echo> <help-echo> <switch-frame> 
<switch-frame> C-x b * s c <tab> <return> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <right> 
C-SPC <down> <down> <down> <down> <down> <down> <down> 
M-w C-x b <return> <help-echo> <switch-frame> <switch-frame> 
M-1 g <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <return> SPC SPC SPC d SPC d d SPC SPC d 
SPC SPC SPC d SPC SPC d SPC SPC d d d SPC d C-z C-z 
C-z C-z C-z C-z C-z C-z C-z C-z C-z C-z C-z C-z C-z 
C-z C-z C-z C-z C-z C-z C-z C-z C-z C-z C-z C-z C-z 
C-z C-z C-z C-z C-z C-z C-z C-z C-z C-z C-z C-z C-z 
C-z C-z C-z C-z C-z C-z C-z d d C-z C-z C-z C-z C-z 
C-z C-z C-z C-z C-z C-z C-z C-z M-z C-z M-z d C-z C-z 
C-z C-z C-z C-z C-z C-z C-z C-z C-z C-z C-z C-z C-z 
d SPC <C-home> C-x C-s <switch-frame> M-x r e p o r 
t - e m a <tab> <return>

Recent messages:
Mark set
Getting mail from d:/usr/eli/data/mail.new...
Counting new messages...done (15)
Saving file d:/usr/eli/rmail/INBOX...
Wrote d:/usr/eli/rmail/INBOX
Computing summary lines...done
15 new messages read
Mark set
Saving file d:/usr/eli/rmail/INBOX...
Wrote d:/usr/eli/rmail/INBOX

Load-path shadows:
None found.

Features:
(shadow emacsbug vc-dispatcher tramp-imap epa derived epg epg-config
imap-hash imap assoc tramp-gw tramp-fish tramp-cache tramp-ftp
tramp-cmds tramp shell format-spec tramp-compat trampver rmailout
auth-source message ecomplete rfc822 mml mml-sec password-cache
mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231 rfc2047
rfc2045 qp ietf-drums nnheader gnus-util netrc mm-util mail-prsvr
gmm-utils wid-edit mailheader canlock hashcash smtpmail multi-isearch
help-mode view dabbrev mailalias conf-mode newcomment ld-script
sh-script executable dired-x dired-aux dired tcl generic nxml-uchnm
rng-xsd xsd-regexp rng-cmpct rng-nxml rng-valid rng-loc rng-uri
rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns
nxml-mode nxml-outln nxml-rap nxml-util nxml-glyph nxml-enc xmltok
sgml-mode arc-mode archive-mode jka-compr make-mode parse-time vc-cvs
python-21 python comint ring org-wl org-w3m org-vm org-rmail org-mhe
org-mew org-irc org-jsinfo org-infojs org-html org-exp org-exp-blocks
org-agenda org-info org-gnus org-bibtex org-bbdb org byte-opt bytecomp
byte-compile advice help-fns advice-preload org-footnote org-src
org-list org-faces org-compat org-macs time-date noutline outline
easy-mmode info vc-bzr sha1 hex-util cc-mode cc-fonts easymenu
cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs
mailabbrev flyspell ispell sendmail regexp-opt rmailsum rmail
mail-utils desktop server filecache saveplace generic-x paren battery
time tooltip ediff-hook vc-hooks lisp-float-type mwheel dos-w32
disp-table ls-lisp w32-win w32-vars tool-bar dnd fontset image fringe
lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar
mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple
abbrev loaddefs button minibuffer faces cus-face files text-properties
overlay md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process multi-tty
emacs)

bug#5493: 23.1.91; Visiting a versioned file while bzr is running signals an error

[Eli Zaretskii]

> Date: Fri, 29 Jan 2010 14:42:50 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 
> 
> Bazaar docs says that "bzr info" can be used to show what locks are
> open.  I couldn't get this to work (will ask on the Bazaar list)

Turns out this is a missing feature in Bazaar.  I filed a bug report
asking to add such a feature:

   https://bugs.launchpad.net/bzr/+bug/514504

bug#5493: 23.1.91; Visiting a versioned file while bzr is running signals an error

[Glenn Morris]

I know what you mean, but I'm having trouble reproducing it right now
for some reason. Maybe recent bzr versions reduced this problem?

Anyway, a suggestion: maybe there is some file in .bzr/ that indicates
when a lock is held. If so, no need to run `bzr info', Emacs can just
check directly for presence of said file.

bug#5493: 23.1.91; Visiting a versioned file while bzr is running signals an error

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Cc: 5493@debbugs.gnu.org
> Date: Tue, 01 Mar 2011 23:23:29 -0500
> 
> 
> I know what you mean, but I'm having trouble reproducing it right now
> for some reason. Maybe recent bzr versions reduced this problem?

Right, I don't see it anymore, at least not with "bzr log".  "bzr ci"
will probably still have this effect, though.

> Anyway, a suggestion: maybe there is some file in .bzr/ that indicates
> when a lock is held.

I don't think so, at least not on Windows: the lock is taken by
issuing a system call.

bug#5493: 23.1.91; Visiting a versioned file while bzr is running signals an error

[Lars Magne Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> I know what you mean, but I'm having trouble reproducing it right now
>> for some reason. Maybe recent bzr versions reduced this problem?
>
> Right, I don't see it anymore, at least not with "bzr log".  "bzr ci"
> will probably still have this effect, though.

So this report can be closed?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#5493: 23.1.91; Visiting a versioned file while bzr is running signals an error

[Eli Zaretskii]

> From: Lars Magne Ingebrigtsen <larsi@gnus.org>
> Cc: Glenn Morris <rgm@gnu.org>,  5493@debbugs.gnu.org
> Date: Sun, 18 Sep 2011 13:50:31 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> I know what you mean, but I'm having trouble reproducing it right now
> >> for some reason. Maybe recent bzr versions reduced this problem?
> >
> > Right, I don't see it anymore, at least not with "bzr log".  "bzr ci"
> > will probably still have this effect, though.
> 
> So this report can be closed?

No.  The problem still exists, at least on Windows, if you replace
"bzr log" in the original report by "bzr update" or "bzr ci".

I guess you can classify this as wishlist, though (and w32-specific; I
cannot reproduce it on GNU/Linux).

bug#5493: 23.1.91; Visiting a versioned file while bzr is running signals an error

[Stefan Monnier]

>>> I know what you mean, but I'm having trouble reproducing it right now
>>> for some reason. Maybe recent bzr versions reduced this problem?
>> Right, I don't see it anymore, at least not with "bzr log".  "bzr ci"
>> will probably still have this effect, though.
> So this report can be closed?

I think you can close it as WONTFIX because it's fundamentally a problem
in Bazaar (which someone was working on fixing, but AFAICT the problem
is still not fixed in the Bazaar version I use).


        Stefan

bug#5493: 23.1.91; Visiting a versioned file while bzr is running signals an error

[Glenn Morris]

I think enough time has passed that this wontfix issue can be closed.