From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11860: 24.1; Arabic - Harakat (diacritics, short vowels) don't appear Date: Tue, 11 Sep 2012 20:48:36 +0300 Message-ID: <83k3w0wivf.fsf@gnu.org> References: <349071341393469@web30d.yandex.ru> <87bohcty0r.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1347385767 16701 80.91.229.3 (11 Sep 2012 17:49:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 11 Sep 2012 17:49:27 +0000 (UTC) Cc: 11860@debbugs.gnu.org, smias@yandex.ru To: Kenichi Handa Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 11 19:49:28 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TBUaW-0007oM-8F for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Sep 2012 19:49:28 +0200 Original-Received: from localhost ([::1]:60766 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBUaS-0004Po-Nd for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Sep 2012 13:49:24 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBUaQ-0004Pj-JZ for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 13:49:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBUaP-0007mo-HJ for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 13:49:22 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBUaP-0007mk-DX for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 13:49:21 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TBUb4-0004pZ-5A for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 13:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Sep 2012 17:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11860 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11860-submit@debbugs.gnu.org id=B11860.134738575418506 (code B ref 11860); Tue, 11 Sep 2012 17:50:02 +0000 Original-Received: (at 11860) by debbugs.gnu.org; 11 Sep 2012 17:49:14 +0000 Original-Received: from localhost ([127.0.0.1]:55064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBUaH-0004oQ-Fw for submit@debbugs.gnu.org; Tue, 11 Sep 2012 13:49:13 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:61029) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBUaE-0004oH-Tv for 11860@debbugs.gnu.org; Tue, 11 Sep 2012 13:49:12 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MA700G005FZRV00@a-mtaout22.012.net.il> for 11860@debbugs.gnu.org; Tue, 11 Sep 2012 20:48:27 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MA700G9J5GR10D0@a-mtaout22.012.net.il>; Tue, 11 Sep 2012 20:48:27 +0300 (IDT) In-reply-to: <87bohcty0r.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:64151 Archived-At: > From: Kenichi Handa > Date: Tue, 11 Sep 2012 23:49:40 +0900 > Cc: 11860@debbugs.gnu.org, smias@yandex.ru > > > IMO, dividing glyphs into grapheme clusters is font backed driver's > > task, and I don't understand why Ffont_shape_gstring merges the > > grapheme clusters for some cases. Could you explain? > > When I designed it, I consider such a situation that > grapheme clusters returned by a font-driver is so fine for > Emacs' display engine that Ffont_shape_gstring must combine > some of them into one grapheme cluster. But, I agree that > it's much cleaner to make a font-driver to consider such a > thing. AFAICS, all Ffont_shape_gstring does is modify the FROM and TO components of the glyph-string. For this to have any effect on the screen, these components need to be used by the drawing routines. But the code in xterm.c and w32term.c that draws the composite characters (x_draw_composite_glyph_string_foreground) doesn't seem to use these components. At least for w32term.c, we just draw the glyphs returned by the shaper, one by one. What am I missing? Where does this "merge" of glyphs into a single grapheme cluster come into play when displaying the glyphs?