unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: ma.jiehong@gmail.com, 12723@debbugs.gnu.org
Subject: bug#12723: 24.2; Improvement: changing text rectangle kill/past and its integration	with the kill-ring
Date: Thu, 25 Oct 2012 21:43:19 +0200	[thread overview]
Message-ID: <83k3ue9w2w.fsf@gnu.org> (raw)
In-Reply-To: <jwvip9y8l29.fsf-monnier+emacs@gnu.org>

> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: ma.jiehong@gmail.com, 12723@debbugs.gnu.org
> Date: Thu, 25 Oct 2012 14:33:31 -0400
> 
> > It's one thing to leave the rectangle to the user's imagination and
> > mental models; it's quite another to actually show that to her.  It's
> > quite possible the users today don't even bother looking what's
> > between the two corners of the region.  With it highlighted, they
> > don't have a chance.
> 
> There are several easy ways out:
> - Let the user turn off highlighting.
> - Let the user not look at the highlighting.
> - Don't highlight if the text contains a mix of L2R and R2L (or just
>   highlight it in a simpler way that only shows the position of the
>   mark).

How about this additional alternative: overlay the marked rectangle
with an overlay (pun intended) which has a 'display' property, a
string that's a copy of the marked text with a newline appended to
each (partial) line?  This display string will then look correctly
with or without bidirectional text, and it will also show the user how
the text will look if yanked into an empty buffer.  The only problem
is that sometimes some of the marked text will show to the left or
right of the overlay, but that's tolerable, I think, and we could make
the surrounding text pale so it's almost invisible.

> I think it should highlight the text actually selected, which doesn't
> give us much leeway.

The above suggestion fulfills that requirement.

> All I know is that the rectangle highlighting won't need complex
> bidi-aware code.  At most it will have to detect that there's bidi
> involved and fallback to another highlighting method.

A method that changes depending on the scripts involved would be
confusing, I think.





  reply	other threads:[~2012-10-25 19:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24 17:40 bug#12723: 24.2; Improvement: changing text rectangle kill/past and its integration with the kill-ring Jiehong Ma
2012-10-24 18:59 ` Stefan Monnier
2012-10-24 21:35   ` Eli Zaretskii
2012-10-25  2:22     ` Stefan Monnier
2012-10-25  3:56       ` Eli Zaretskii
2012-10-25 12:28         ` Stefan Monnier
2012-10-25 16:53           ` Eli Zaretskii
2012-10-25 18:33             ` Stefan Monnier
2012-10-25 19:43               ` Eli Zaretskii [this message]
2012-10-26  1:34                 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k3ue9w2w.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=12723@debbugs.gnu.org \
    --cc=ma.jiehong@gmail.com \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).