From: Eli Zaretskii <eliz@gnu.org>
To: Alex Dunn <dunn.alex@gmail.com>
Cc: 22046@debbugs.gnu.org
Subject: bug#22046: [PATCH] Improve version-to-list parsing
Date: Tue, 01 Dec 2015 05:38:49 +0200 [thread overview]
Message-ID: <83k2oyltx2.fsf@gnu.org> (raw)
In-Reply-To: <m27fky539c.fsf@snow.i-did-not-set--mail-host-address--so-tickle-me>
> From: Alex Dunn <dunn.alex@gmail.com>
> Cc: 22046@debbugs.gnu.org
> Date: Mon, 30 Nov 2015 18:09:03 -0800
>
> The recipes MELPA uses for building packages are usually just the name,
> the repository, and the method of fetching it (git, svn, etc). To
> figure out if there’s a stable version of the package, MELPA parses the
> repository’s tags; if the tags aren’t valid version-strings (according
> to version-to-list) it assumes there isn’t a stable version available
> and packages it as “HEAD-only”.
>
> So MELPA is at the mercy of upstream developers’ tagging practices, and
> sometimes they do things like “OTP-18.0.5”: https://github.com/erlang/otp/tags
>
> Another solution to this particular problem is for MELPA to allow their
> recipes to specify a custom version schema; but my thought was that
> making version-to-list more flexible was a good thing. Parsing git tags
> seems like a common enough use-case that it might be nice to have this.
Sounds to me as a MELPA-specific problem that should be solved there,
not in Emacs.
> But it’s true that with this change some very long strings will be
> parsed as valid. This returns '(0 9), which is sort of ridiculous:
>
> (version-to-list "It’s true that with this change some very long strings will be parsed as valid: 0.9")
>
> But I guess I’m not sure what the danger is in letting that happen. Is
> version-to-list often used to parse arbitrary strings, where false
> positives would cause problems?
I just don't see a reason for such a radical change in behavior of a
feature that has been very stable lately.
Thanks.
next prev parent reply other threads:[~2015-12-01 3:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 22:26 bug#22046: [PATCH] Improve version-to-list parsing Alex Dunn
2015-11-30 0:09 ` Alex Dunn
2015-11-30 3:34 ` Eli Zaretskii
2015-11-30 3:54 ` Alex Dunn
2015-11-30 7:59 ` Andreas Schwab
2015-11-30 15:50 ` Eli Zaretskii
2015-12-01 2:09 ` Alex Dunn
2015-12-01 3:38 ` Eli Zaretskii [this message]
2015-12-02 4:14 ` Alex Dunn
2015-12-05 9:36 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k2oyltx2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=22046@debbugs.gnu.org \
--cc=dunn.alex@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).