From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22241: 25.0.50; etags Ruby parser problems Date: Sat, 30 Jan 2016 14:21:13 +0200 Message-ID: <83k2mrw952.fsf@gnu.org> References: <86r3i9hnbt.fsf@yandex.ru> <83si1o45g1.fsf@gnu.org> <56A3C53D.1050408@yandex.ru> <83oacc3yx7.fsf@gnu.org> <56A3D47E.3030802@yandex.ru> <83mvrw3tuj.fsf@gnu.org> <56A3F3F9.8030404@yandex.ru> <8360yj3rtf.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1454156539 3138 80.91.229.3 (30 Jan 2016 12:22:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Jan 2016 12:22:19 +0000 (UTC) Cc: 22241@debbugs.gnu.org To: dgutov@yandex.ru Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 30 13:22:07 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aPUXX-00078t-3X for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Jan 2016 13:22:07 +0100 Original-Received: from localhost ([::1]:38471 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPUXW-0006uw-7h for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Jan 2016 07:22:06 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38571) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPUXS-0006ub-NG for bug-gnu-emacs@gnu.org; Sat, 30 Jan 2016 07:22:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aPUXR-0006ns-Qg for bug-gnu-emacs@gnu.org; Sat, 30 Jan 2016 07:22:02 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPUXR-0006no-N1 for bug-gnu-emacs@gnu.org; Sat, 30 Jan 2016 07:22:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aPUXR-0005jl-J5 for bug-gnu-emacs@gnu.org; Sat, 30 Jan 2016 07:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Jan 2016 12:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22241 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22241-submit@debbugs.gnu.org id=B22241.145415651522036 (code B ref 22241); Sat, 30 Jan 2016 12:22:01 +0000 Original-Received: (at 22241) by debbugs.gnu.org; 30 Jan 2016 12:21:55 +0000 Original-Received: from localhost ([127.0.0.1]:41047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aPUXL-0005jM-Bd for submit@debbugs.gnu.org; Sat, 30 Jan 2016 07:21:55 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47556) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aPUXK-0005jA-Ia for 22241@debbugs.gnu.org; Sat, 30 Jan 2016 07:21:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aPUXA-0006j1-O9 for 22241@debbugs.gnu.org; Sat, 30 Jan 2016 07:21:49 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39520) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPUXA-0006ix-Ko; Sat, 30 Jan 2016 07:21:44 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1795 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aPUX9-000524-Ub; Sat, 30 Jan 2016 07:21:44 -0500 In-reply-to: <8360yj3rtf.fsf@gnu.org> (message from Eli Zaretskii on Sun, 24 Jan 2016 17:44:44 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112105 Archived-At: > Date: Sun, 24 Jan 2016 17:44:44 +0200 > From: Eli Zaretskii > Cc: 22241@debbugs.gnu.org > > > Cc: 22241@debbugs.gnu.org > > From: Dmitry Gutov > > Date: Sun, 24 Jan 2016 00:43:21 +0300 > > > > On 01/23/2016 11:48 PM, Eli Zaretskii wrote: > > > > >> ^[ \t]([A-Z][a-z0-9_])[ \t]*=[ \t]* > > > > ^ I missed a * there. > > > > >> ? Then record the first group, and simply don't look at what's being > > >> assigned. > > > > > > That's possible, but is it good enough? Does the above regexp > > > necessarily mean it's a constant? > > > > I think so. The important point is that its name begins with a capital > > letter. > > > > And we should probably recognize assignments like these: > > > > ModuleExample::CONSTANT = 5 > > > > The qualified name "ModuleExample::CONSTANT" if at the top level, > > unqualified name is "CONSTANT". When inside classes, modules or methods, > > only record the unqualified name; maybe disregard these assignments when > > inside methods altogether. > > OK, thanks. I will see what I can do with this. Please take a look at the results of commit 25b79d7 on the emacs-25 branch. I think I implemented everything except the optional name qualification. I hope the results are good enough. If you agree, please close the bug. Of course, if there are still bugs, or the implementation doesn't catch some use cases, please show them. Thanks.