From: Eli Zaretskii <eliz@gnu.org>
To: eggert@cs.ucla.edu
Cc: oub@mat.ucm.es, dgutov@yandex.ru, 23595@debbugs.gnu.org
Subject: bug#23595: 25.1.50; file with chinese/japanse chars, vc-diff fails (HG, Git, RCS)
Date: Tue, 24 May 2016 18:36:59 +0300 [thread overview]
Message-ID: <83k2ij4gdg.fsf@gnu.org> (raw)
In-Reply-To: <83shx841qr.fsf@gnu.org> (message from Eli Zaretskii on Tue, 24 May 2016 05:40:44 +0300)
> Date: Tue, 24 May 2016 05:40:44 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: oub@mat.ucm.es, dgutov@yandex.ru, 23595@debbugs.gnu.org
>
> > It worked for me in the Bug#23595 test case, with Git configured with
> > utf16<->utf8 filters as I described. However, it reintroduces a bug when
> > the version-controlled uses ISO-2022-JP. If I make a trivial change to
> > etc/HELLO, for example, the patch can cause vc-diff to display mojibake,
> > as the output of "git diff" uses ISO0-2022-JP but vc-diff decodes it as
> > UTF-8. Although this is the same mojibake that Emacs 24.5 generates so
> > the behavior is not a regression from 24.5, it is a regression from
> > current emacs-25.
>
> For some reason I don't quite understand, iso-2022-jp fails the
> ascii-compatible-p test.
OK, I understand that now. ascii-compatible-p is not the right test,
the right one is mime-text-unsuitable-p; and the test should be
reversed, i.e. this:
(coding-system-get CODING-SYSTEM :mime-text-unsuitable-p)
should return nil for CODING-SYSTEM to be usable.
next prev parent reply other threads:[~2016-05-24 15:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-21 13:02 bug#23595: 25.1.50; file with chinese/japanse chars, vc-diff fails (HG, Git, RCS) Uwe Brauer
2016-05-23 11:52 ` Dmitry Gutov
2016-05-23 12:41 ` Uwe Brauer
2016-05-23 13:17 ` Dmitry Gutov
2016-05-23 16:52 ` Eli Zaretskii
2016-05-23 16:51 ` Eli Zaretskii
2016-05-23 16:48 ` Eli Zaretskii
2016-05-23 17:00 ` Uwe Brauer
2016-05-23 17:31 ` Eli Zaretskii
2016-05-23 20:37 ` Uwe Brauer
2016-05-23 21:01 ` Lars Ingebrigtsen
2016-05-24 2:33 ` Eli Zaretskii
2016-05-23 21:02 ` Dmitry Gutov
2016-05-23 22:16 ` Paul Eggert
2016-05-23 22:28 ` Dmitry Gutov
2016-05-24 0:07 ` Paul Eggert
2016-05-24 9:47 ` Dmitry Gutov
2016-05-25 6:51 ` Paul Eggert
2016-05-25 12:44 ` Dmitry Gutov
2016-05-24 2:40 ` Eli Zaretskii
2016-05-24 15:36 ` Eli Zaretskii [this message]
2016-05-24 2:36 ` Eli Zaretskii
2016-05-24 9:35 ` Dmitry Gutov
2016-05-24 15:40 ` Eli Zaretskii
2016-05-25 0:09 ` Dmitry Gutov
2016-05-25 16:22 ` Eli Zaretskii
2016-05-25 23:21 ` Dmitry Gutov
2016-05-26 10:44 ` Uwe Brauer
2016-05-26 15:35 ` Eli Zaretskii
2016-06-19 19:09 ` Dmitry Gutov
2016-05-25 6:19 ` Paul Eggert
2016-05-25 16:27 ` Eli Zaretskii
2016-05-25 6:19 ` Paul Eggert
2016-05-25 16:26 ` Eli Zaretskii
2016-05-23 17:40 ` Paul Eggert
2016-05-23 18:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k2ij4gdg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23595@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=eggert@cs.ucla.edu \
--cc=oub@mat.ucm.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).