unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Hong Xu <hong@topbug.net>
Cc: 24879@debbugs.gnu.org
Subject: bug#24879: [PATCH] Point out the default value of FRAME in the `set-face-*' functions.
Date: Fri, 04 Nov 2016 23:31:50 +0200	[thread overview]
Message-ID: <83k2cjj5ix.fsf@gnu.org> (raw)
In-Reply-To: <1478291350-19807-1-git-send-email-hong@topbug.net> (message from Hong Xu on Fri, 4 Nov 2016 13:29:10 -0700)

> From: Hong Xu <hong@topbug.net>
> Date: Fri,  4 Nov 2016 13:29:10 -0700
> 
>    The following commands and functions mostly provide compatibility
>  with old versions of Emacs.  They work by calling
> -@code{set-face-attribute}.  Values of @code{t} and @code{nil} for
> -their @var{frame} argument are handled just like
> +@code{set-face-attribute}.  Values of @code{t} and @code{nil}
> +(default) for their @var{frame} argument are handled just like
>  @code{set-face-attribute} and @code{face-attribute}.  The commands
>  read their arguments using the minibuffer, if called interactively.

Do we really need to tell people that an omitted argument defaults to
nil?  And if we do, why in this section?

Thanks.





  reply	other threads:[~2016-11-04 21:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-04 20:29 bug#24879: [PATCH] Point out the default value of FRAME in the `set-face-*' functions Hong Xu
2016-11-04 21:31 ` Eli Zaretskii [this message]
2016-11-05  8:17   ` Hong Xu
2016-11-05  8:56     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k2cjj5ix.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=24879@debbugs.gnu.org \
    --cc=hong@topbug.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).