From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24603: [RFC 16/18] Refactor character class checking; optimise ASCII case Date: Sun, 06 Nov 2016 21:44:53 +0200 Message-ID: <83k2cgiea2.fsf@gnu.org> References: <1475543441-10493-1-git-send-email-mina86@mina86.com> <1475543441-10493-16-git-send-email-mina86@mina86.com> <837f9oo8q3.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1478461540 2199 195.159.176.226 (6 Nov 2016 19:45:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 6 Nov 2016 19:45:40 +0000 (UTC) Cc: 24603@debbugs.gnu.org To: Michal Nazarewicz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 06 20:45:35 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3TNM-00055E-D2 for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Nov 2016 20:45:08 +0100 Original-Received: from localhost ([::1]:46904 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3TNP-0001bk-DO for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Nov 2016 14:45:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3TNJ-0001a4-8x for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2016 14:45:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3TNG-00086q-6u for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2016 14:45:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59980) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c3TNG-00086e-3n for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2016 14:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c3TNF-0004Qk-Ro for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2016 14:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Nov 2016 19:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24603 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24603-submit@debbugs.gnu.org id=B24603.147846149317003 (code B ref 24603); Sun, 06 Nov 2016 19:45:01 +0000 Original-Received: (at 24603) by debbugs.gnu.org; 6 Nov 2016 19:44:53 +0000 Original-Received: from localhost ([127.0.0.1]:47146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3TN7-0004QB-Ao for submit@debbugs.gnu.org; Sun, 06 Nov 2016 14:44:53 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3TN6-0004Ps-3B for 24603@debbugs.gnu.org; Sun, 06 Nov 2016 14:44:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3TMx-0007sH-RF for 24603@debbugs.gnu.org; Sun, 06 Nov 2016 14:44:46 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3TMx-0007s8-Oq; Sun, 06 Nov 2016 14:44:43 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1241 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c3TMv-0003B2-2G; Sun, 06 Nov 2016 14:44:43 -0500 In-reply-to: (message from Michal Nazarewicz on Sun, 06 Nov 2016 20:26:11 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125393 Archived-At: > From: Michal Nazarewicz > Cc: 24603@debbugs.gnu.org > Date: Sun, 06 Nov 2016 20:26:11 +0100 > > On Tue, Oct 04 2016, Eli Zaretskii wrote: > > Thanks. I think this change will require a benchmark to make sure we > > don't lose too much in terms of performance. > > Benchmark and its results included below. > > It’s a bit noisy and as all benchmarks of that kind it doesn’t really > measure the real usage, but I think it’s safe to say that things aren’t > getting worse. Thanks. What happened here: > ==== Refactor character class checking; optimise ASCII case ==== > alnum 54.643 54.301 56.668 56.898 > alpha 54.654 54.558 56.134 56.281 > digit 26.103 26.044 0.495 0.443 > xdigit 25.606 25.690 0.815 0.806 > upper 83.269 83.306 36.704 36.487 > lower 56.278 55.804 54.872 54.917 > word 34.820 55.092 99.577 100.618 ^^^^^^ Is this slow-down real? The rest of the results look fine to me.