From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24543: 25.1; describe-symbol doesn't show face with same name as a variable Date: Fri, 28 Jul 2017 10:35:02 +0300 Message-ID: <83k22t3tg9.fsf@gnu.org> References: <87d1jrzufs.fsf@gmail.com> <87shizwqca.fsf@lylat> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1501227384 22787 195.159.176.226 (28 Jul 2017 07:36:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 28 Jul 2017 07:36:24 +0000 (UTC) Cc: 24543@debbugs.gnu.org To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 28 09:36:18 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dazog-0005Eo-NH for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Jul 2017 09:36:10 +0200 Original-Received: from localhost ([::1]:46535 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dazom-0005Kg-Dd for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Jul 2017 03:36:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dazod-0005J3-Tl for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2017 03:36:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dazoY-0000rh-Rv for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2017 03:36:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56458) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dazoY-0000rV-Nv for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2017 03:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dazoY-0003ZP-J1 for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2017 03:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jul 2017 07:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24543 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24543-submit@debbugs.gnu.org id=B24543.150122733113683 (code B ref 24543); Fri, 28 Jul 2017 07:36:02 +0000 Original-Received: (at 24543) by debbugs.gnu.org; 28 Jul 2017 07:35:31 +0000 Original-Received: from localhost ([127.0.0.1]:59135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dazo3-0003Yc-Dl for submit@debbugs.gnu.org; Fri, 28 Jul 2017 03:35:31 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dazo1-0003YQ-G9 for 24543@debbugs.gnu.org; Fri, 28 Jul 2017 03:35:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daznr-0000EB-EQ for 24543@debbugs.gnu.org; Fri, 28 Jul 2017 03:35:24 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34600) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daznr-0000Dz-BK; Fri, 28 Jul 2017 03:35:19 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3036 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1daznp-00021i-Q2; Fri, 28 Jul 2017 03:35:19 -0400 In-reply-to: <87shizwqca.fsf@lylat> (message from Alex on Fri, 16 Jun 2017 15:54:45 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135065 Archived-At: > From: Alex > Date: Fri, 16 Jun 2017 15:54:45 -0600 > > > emacs -Q > > C-h o font-lock-comment-face RET > > > > Only the variable of this name is shown, not the face (which can be > > viewed with describe-face, of course). > > > > It appears that when the face only shares a name with a function, then > > both the function and face are shown. Only a variable shadows the face > > in describe-symbol. > > This is because describe-symbol isn't returning (buffer-string) like > describe-{function, variable} are. > > I've attached a patch fixing this problem. Thanks. This LGTM, but doesn't the fact that describe-face's return value will change after this constitute an incompatible change? And if so, could it break some of the users of this function out there?