unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alex <agrambot@gmail.com>
Cc: 24543@debbugs.gnu.org
Subject: bug#24543: 25.1; describe-symbol doesn't show face with same name as a variable
Date: Fri, 28 Jul 2017 10:35:02 +0300	[thread overview]
Message-ID: <83k22t3tg9.fsf@gnu.org> (raw)
In-Reply-To: <87shizwqca.fsf@lylat> (message from Alex on Fri, 16 Jun 2017 15:54:45 -0600)

> From: Alex <agrambot@gmail.com>
> Date: Fri, 16 Jun 2017 15:54:45 -0600
> 
> > emacs -Q
> > C-h o font-lock-comment-face RET
> >
> > Only the variable of this name is shown, not the face (which can be
> > viewed with describe-face, of course).
> >
> > It appears that when the face only shares a name with a function, then
> > both the function and face are shown. Only a variable shadows the face
> > in describe-symbol.
> 
> This is because describe-symbol isn't returning (buffer-string) like
> describe-{function, variable} are.
> 
> I've attached a patch fixing this problem.

Thanks.  This LGTM, but doesn't the fact that describe-face's return
value will change after this constitute an incompatible change?  And
if so, could it break some of the users of this function out there?





  parent reply	other threads:[~2017-07-28  7:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-25 18:49 bug#24543: 25.1; describe-symbol doesn't show face with same name as a variable Alex
2017-06-16 21:54 ` Alex
2017-07-26  4:28   ` Alex
2017-07-26 14:45     ` Eli Zaretskii
2017-07-28  7:35   ` Eli Zaretskii [this message]
2017-07-28 20:45     ` Alex
2017-08-05  8:53       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k22t3tg9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=24543@debbugs.gnu.org \
    --cc=agrambot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).