From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27114: 25.2: fringe click echoes "Emacs-Lisp:" in emacs-lisp mode Date: Sun, 20 Aug 2017 17:58:31 +0300 Message-ID: <83k21ycmlk.fsf@gnu.org> References: <87y3te2awi.fsf@users.sourceforge.net> <838tldee8x.fsf@gnu.org> <87fud0731u.fsf@lylat> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1503241156 7043 195.159.176.226 (20 Aug 2017 14:59:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 20 Aug 2017 14:59:16 +0000 (UTC) Cc: agrambot@gmail.com, 27114@debbugs.gnu.org, npostavs@users.sourceforge.net To: charles@aurox.ch (Charles A. Roelli) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 20 16:59:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djRgs-00018B-3l for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Aug 2017 16:59:02 +0200 Original-Received: from localhost ([::1]:56684 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djRgy-0008DB-RV for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Aug 2017 10:59:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djRgt-0008Ch-0f for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2017 10:59:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djRgs-0001P8-7c for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2017 10:59:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38129) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1djRgs-0001Oq-3X for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2017 10:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1djRgr-00074c-SJ for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2017 10:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2017 14:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27114 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27114-submit@debbugs.gnu.org id=B27114.150324113127173 (code B ref 27114); Sun, 20 Aug 2017 14:59:01 +0000 Original-Received: (at 27114) by debbugs.gnu.org; 20 Aug 2017 14:58:51 +0000 Original-Received: from localhost ([127.0.0.1]:46810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djRgg-00074D-PX for submit@debbugs.gnu.org; Sun, 20 Aug 2017 10:58:50 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56031) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djRge-000740-U5 for 27114@debbugs.gnu.org; Sun, 20 Aug 2017 10:58:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djRgW-0001Cy-N9 for 27114@debbugs.gnu.org; Sun, 20 Aug 2017 10:58:43 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djRgW-0001Ci-Jn; Sun, 20 Aug 2017 10:58:40 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4160 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1djRgU-0000Gv-8R; Sun, 20 Aug 2017 10:58:39 -0400 In-reply-to: (charles@aurox.ch) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135944 Archived-At: > Date: Sun, 20 Aug 2017 16:14:40 +0200 > From: charles@aurox.ch (Charles A. Roelli) > CC: eliz@gnu.org, npostavs@users.sourceforge.net, > 27114@debbugs.gnu.org > > > --- a/lisp/progmodes/elisp-mode.el > > +++ b/lisp/progmodes/elisp-mode.el > > @@ -45,7 +45,7 @@ emacs-lisp-mode-syntax-table > > "Syntax table used in `emacs-lisp-mode'.") > > > > (defvar emacs-lisp-mode-map > > - (let ((map (make-sparse-keymap "Emacs-Lisp")) > > + (let ((map (make-sparse-keymap)) > > (menu-map (make-sparse-keymap "Emacs-Lisp")) > > (lint-map (make-sparse-keymap)) > > (prof-map (make-sparse-keymap)) > > Thanks for finding this out. The function that prints "Emacs-Lisp:" > to the echo area during the click is "read_char_minibuf_menu_prompt" > (keyboard.c), which calls Fkeymap_prompt (which in the scenario of > this bug, returns "Emacs-Lisp"), and eventually executes these lines: > > /* Prompt with that and read response. */ > message3_nolog (apply1 (intern ("concat"), Fnreverse (menu_strings))); > > Maybe it's wrong for "read_char" to call this function > ("read_char_minibuf_menu_prompt") for some click events. No, it's not wrong. It's a feature: it provides visual feedback for incomplete mouse clicks. The ELisp manual explicitly says to provide this string, which it calls "overall prompt", for all keymaps that can be menus. Which this keymap can. (If you make the proposed change, and then visit some .el file and click C-mouse-3, what do you see in the header of the pop-up menu?) What I don't quite understand is why mouse-1 on the fringe invokes lisp-mode-map. Can you tell where's the offending binding which causes that? Thanks.