From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions Date: Fri, 06 Oct 2017 15:43:49 +0300 Message-ID: <83k208v43e.fsf@gnu.org> References: <83lglio36q.fsf@gnu.org> <20170924131050.6erv6sshvz23dlbu@odonien.localdomain> <838tgy9d18.fsf@gnu.org> <877ew9vqwv.fsf@mouse.gnus.org> <83vajtx3hu.fsf@gnu.org> <87wp49u9ki.fsf@mouse.gnus.org> <83shexwxce.fsf@gnu.org> <87lgkpu3tl.fsf@mouse.gnus.org> <83poa1wvxi.fsf@gnu.org> <87d161u2g8.fsf@mouse.gnus.org> <20171005200807.ysmclhv5cxuwsnap@odonien.localdomain> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1507293913 4504 195.159.176.226 (6 Oct 2017 12:45:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Oct 2017 12:45:13 +0000 (UTC) Cc: larsi@gnus.org, 28402@debbugs.gnu.org To: Vasilij Schneidermann Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 06 14:45:05 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0S00-0000Kc-4V for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Oct 2017 14:45:04 +0200 Original-Received: from localhost ([::1]:44733 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0S07-0005V5-M5 for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Oct 2017 08:45:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0S02-0005UP-Ex for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2017 08:45:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0Rzy-0004dC-Ik for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2017 08:45:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43711) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0Rzy-0004cb-Fk for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2017 08:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e0Rzy-0007t4-6c for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2017 08:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Oct 2017 12:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28402-submit@debbugs.gnu.org id=B28402.150729384930219 (code B ref 28402); Fri, 06 Oct 2017 12:45:02 +0000 Original-Received: (at 28402) by debbugs.gnu.org; 6 Oct 2017 12:44:09 +0000 Original-Received: from localhost ([127.0.0.1]:52391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0Rz7-0007rL-22 for submit@debbugs.gnu.org; Fri, 06 Oct 2017 08:44:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0Rz6-0007r7-0I for 28402@debbugs.gnu.org; Fri, 06 Oct 2017 08:44:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0Ryw-0003et-Uo for 28402@debbugs.gnu.org; Fri, 06 Oct 2017 08:44:02 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0Ryw-0003eo-Qp; Fri, 06 Oct 2017 08:43:58 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4744 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e0Ryw-00057T-4Z; Fri, 06 Oct 2017 08:43:58 -0400 In-reply-to: <20171005200807.ysmclhv5cxuwsnap@odonien.localdomain> (message from Vasilij Schneidermann on Thu, 5 Oct 2017 22:08:07 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138015 Archived-At: > Date: Thu, 5 Oct 2017 22:08:07 +0200 > From: Vasilij Schneidermann > Cc: Eli Zaretskii , 28402@debbugs.gnu.org > > I can imagine other variations of defsubst (such as defmacro and > define-inline), but it would indeed be the easiest to roll back that > part of the code. What I'd additionally do is adding a comment > explaining why there's two very similar snippets of code doing the same > thing, otherwise the next person proposing a patch will change only one > of them and be left head-scratching why it doesn't quite work. Thanks, done.