unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Allen Li <vianchielfaura@gmail.com>
Cc: 28615@debbugs.gnu.org
Subject: bug#28615: [PATCH] Clarify what grep-read-files wants
Date: Tue, 10 Oct 2017 08:55:26 +0300	[thread overview]
Message-ID: <83k203r1gx.fsf@gnu.org> (raw)
In-Reply-To: <CAJr1M6cmubRuoX_WXtGmnNHG9dchyuNzheDVYiTH2ZcRxGuhhQ@mail.gmail.com> (message from Allen Li on Mon, 9 Oct 2017 21:43:59 -0700)

> From: Allen Li <vianchielfaura@gmail.com>
> Date: Mon, 9 Oct 2017 21:43:59 -0700
> Cc: 28615-done@debbugs.gnu.org
> 
> Why did you not change the collection function?

Because there could be a file called literally like one of the
shorthands in grep-files-aliases, or whose name includes those
shorthands as a substring.

> As I noted in the bug, most of the completions that would be
> provided by read-file-name-internal don't work

IMO, that's okay, because wildcards cannot be meaningfully completed
on.





  reply	other threads:[~2017-10-10  5:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27  7:01 bug#28615: 25.3; rgrep, grep-read-files confusingly completes file names ヌエルモリノ
2017-10-05  4:15 ` bug#28615: [PATCH] Clarify what grep-read-files wants Allen Li
2017-10-09 13:41   ` Eli Zaretskii
2017-10-10  4:43     ` Allen Li
2017-10-10  5:55       ` Eli Zaretskii [this message]
2017-10-10  6:51         ` Allen Li
2017-10-10  7:52           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k203r1gx.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=28615@debbugs.gnu.org \
    --cc=vianchielfaura@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).