From: Eli Zaretskii <eliz@gnu.org>
To: charles@aurox.ch (Charles A. Roelli)
Cc: 30697@debbugs.gnu.org
Subject: bug#30697: make eval-expression only take `read'-able Lisp
Date: Sun, 04 Mar 2018 19:10:55 +0200 [thread overview]
Message-ID: <83k1uru5pc.fsf@gnu.org> (raw)
In-Reply-To: <m27eqriyat.fsf@aurox.ch> (charles@aurox.ch)
> Date: Sun, 04 Mar 2018 17:46:18 +0100
> From: charles@aurox.ch (Charles A. Roelli)
>
> Here is a change to make eval-expression issue a warning in the
> minibuffer when the user enters an unreadable expression. Currently,
> we just error out, so the user has to restart the command and go back
> in the history to get back what he typed.
>
> With the change applied, if you type
>
> M-: ( RET
>
> from emacs -q, you'll see,
>
> Eval: ( [End of file during parsing]
>
> which gives you a chance to fix the error right away.
>
> As another example, if you type an extra paren, as in
>
> M-: ( ) ) RET
>
> you'll see,
>
> Eval: ()) [Trailing garbage following expression]
>
> and point is left at the extra paren.
You are changing the behavior of read--expression, which has a few
callers in Emacs. Did you verify that those callers won't break due
to this change?
This should also have a NEWS entry, and perhaps the manual needs some
changes, please take a look.
Thanks.
next prev parent reply other threads:[~2018-03-04 17:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 16:46 bug#30697: make eval-expression only take `read'-able Lisp Charles A. Roelli
2018-03-04 17:10 ` Eli Zaretskii [this message]
2018-03-05 18:52 ` Charles A. Roelli
2019-06-24 18:58 ` bug#30697: make eval-expression only take `read'-able Lisp, " Lars Ingebrigtsen
2020-08-10 13:17 ` Lars Ingebrigtsen
2020-08-10 13:20 ` Lars Ingebrigtsen
[not found] <<m27eqriyat.fsf@aurox.ch>
2018-03-04 22:36 ` Drew Adams
2018-03-05 19:09 ` Charles A. Roelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k1uru5pc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=30697@debbugs.gnu.org \
--cc=charles@aurox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).