unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: larsi@gnus.org, 31676@debbugs.gnu.org
Subject: bug#31676: 27.0.50; More helpful error message for unescaped character literals
Date: Sat, 09 Jun 2018 20:31:25 +0300	[thread overview]
Message-ID: <83k1r7sw7m.fsf@gnu.org> (raw)
In-Reply-To: <CAArVCkT3pU1m_TFR4Ka4K_xS0EjynbT=PMoiMd3tLqsnx7BUBg@mail.gmail.com> (message from Philipp Stephani on Sat, 9 Jun 2018 19:12:30 +0200)

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sat, 9 Jun 2018 19:12:30 +0200
> Cc: larsi@gnus.org, 31676@debbugs.gnu.org
> 
>  Sounds okay, but can you tell why you implemented
>  lread--unescaped-character-literals in C?  If that's because you need
>  to call it from load_warn_unescaped_character_literals, then C
>  functions can call Lisp functions with no problems, we have several
>  examples of that in the sources.  AFAICT, the C implementation is just
>  a "transliteration" of straightforward Lisp code, so it reads strange.
> 
> The function uses an uninterned variable, so it has to be in C. I think that's slightly better than interning the
> variable and having some Lisp function access it (the latter would have one additional internal symbol). 

Why does it need an uninterned variable?  And if it does, why cannot
it create a symbol that is not in obarray?





  reply	other threads:[~2018-06-09 17:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 10:18 bug#31676: 27.0.50; More helpful error message for unescaped character literals Lars Ingebrigtsen
2018-06-02 10:00 ` Philipp Stephani
2018-06-08 14:51   ` Eli Zaretskii
2018-06-09 17:12     ` Philipp Stephani
2018-06-09 17:31       ` Eli Zaretskii [this message]
2019-04-19  9:54         ` Philipp Stephani
2019-04-19 11:43           ` Noam Postavsky
2019-04-19 15:53             ` Philipp Stephani
2019-04-19 16:33               ` Philipp Stephani
2019-04-19 17:22       ` Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k1r7sw7m.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=31676@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).