unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 32348@debbugs.gnu.org, raman@google.com
Subject: bug#32348: 27.0.50; EWW/SHR: Please add support for hiding DOM nodes with aria-hidden=true
Date: Thu, 16 Aug 2018 16:21:46 +0300	[thread overview]
Message-ID: <83k1oqih05.fsf@gnu.org> (raw)
In-Reply-To: <87a7pnxk6r.fsf@gmail.com> (message from Noam Postavsky on Wed, 15 Aug 2018 19:51:40 -0400)

> From: Noam Postavsky <npostavs@gmail.com>
> Date: Wed, 15 Aug 2018 19:51:40 -0400
> Cc: 32348@debbugs.gnu.org
> 
> I've updated my previous patch with some more documentation, so that
> someone who doesn't know anything about "aria-hidden" (e.g., me, before
> this thread) could have some chance of figuring out what it's good for.
> I'll push to master in a few days.

Thanks, I think the NEWS entry should tell a bit more about the new
option.

> +@vindex shr-discard-aria-hidden
> +@cindex aria-hidden

@cindex could be more reader-friendly, e.g.

  @cindex @code{aria-hidden}, HTML attribute

> +  The HTML attribute @code{aria-hidden} is meant to tell screen
> +readers to ignore a tag's contents.  You can customize the variable
> +@code{shr-discard-aria-hidden} to tell @code{shr} to ignore such tags.
> +This can be useful when using a screen reader on the output of
> +@code{shr} (e.g., on EWW buffer text).  Or even when not using a
> +screen reader, since web authors often put this tag on non-essential
> +decorative content.

The last sentence is incomplete, suggest to either make it part of the
previous one, or say something like "It can be useful even when not..."

Thanks.





  parent reply	other threads:[~2018-08-16 13:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-02 15:25 bug#32348: 27.0.50; EWW/SHR: Please add support for hiding DOM nodes with aria-hidden=true T.V Raman
2018-08-08  0:45 ` Noam Postavsky
2018-08-08 14:27   ` T.V Raman
2018-08-15 23:51     ` Noam Postavsky
2018-08-16  2:23       ` T.V Raman
2018-08-16 11:25         ` Noam Postavsky
2018-08-16 14:09           ` T.V Raman
2018-08-16 13:21       ` Eli Zaretskii [this message]
2018-08-28  0:03         ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k1oqih05.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=32348@debbugs.gnu.org \
    --cc=npostavs@gmail.com \
    --cc=raman@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).