unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jordan Wilson <jordan.t.wilson@gmx.com>
Cc: 32989-done@debbugs.gnu.org
Subject: bug#32989: 26.1; Opening PDF attachments in Gnus with doc-view-mode causes error on Windows
Date: Sat, 03 Nov 2018 10:32:09 +0200	[thread overview]
Message-ID: <83k1lufto6.fsf@gnu.org> (raw)
In-Reply-To: <877eiqhyfu.fsf@gmx.com> (message from Jordan Wilson on Wed, 10 Oct 2018 11:45:57 +0100)

> From: Jordan Wilson <jordan.t.wilson@gmx.com>
> Cc: 32989@debbugs.gnu.org
> Date: Wed, 10 Oct 2018 11:45:57 +0100
> 
> 
> [1:text/plain Hide]
> 
> On 2018-10-08 (Mon) at 23:02 (ZZZ), Eli Zaretskii <eliz@gnu.org> wrote:
> >> From: Jordan Wilson <jordan.t.wilson@gmx.com>
> >> Date: Mon, 08 Oct 2018 15:44:55 +0100
> >> 
> >>   File error: "Opening output file", "Invalid argument", "c:/Users/Jordan/Emacs/.cache/docview-cache/ *mm*-012345" 
> >> 
> >> this leaves a buffer showing the file literally. If I rename that buffer
> >> to something not containing an asterisk, it displays fine when running
> >> "doc-view-mode". Windows apparently can't handle asterisks in
> >> directory/file names.
> >
> > Windows doesn't allow '*' (and a few other characters) in any file
> > name, not just in directory name.  Gnus should run the file name
> > through convert-standard-filename to get something that is guaranteed
> > to work on any filesystem.
> Looking, it seems to be on doc-view's side -- if a buffer isn't
> associated with a file, it uses the buffer name for the file's cache
> directory. Here's a patch to the 26 and trunk branches of doc-view.el to
> run the file names through `convert-standard-filename'. It fixes the
> problem for me, at least.

Thanks, pushed to the emacs-26 branch (will be merged to master from
there shortly).





      parent reply	other threads:[~2018-11-03  8:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 14:44 bug#32989: 26.1; Opening PDF attachments in Gnus with doc-view-mode causes error on Windows Jordan Wilson
2018-10-08 20:02 ` Eli Zaretskii
2018-10-10 10:45   ` Jordan Wilson
2018-10-28 22:57     ` Jordan Wilson
2018-11-03  8:32     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k1lufto6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=32989-done@debbugs.gnu.org \
    --cc=jordan.t.wilson@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).