From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33930: 26.1; [PATCH] Fix `C-x C-k l' (`kmacro-edit-lossage') so it ignores mouse events Date: Sat, 05 Jan 2019 11:38:29 +0200 Message-ID: <83k1jj1m22.fsf@gnu.org> References: <081600a4-0b81-4123-9214-c6db840e8169@default> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1546681033 17579 195.159.176.226 (5 Jan 2019 09:37:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 5 Jan 2019 09:37:13 +0000 (UTC) Cc: 33930-done@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 05 10:37:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from listsout.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfiOA-0004Qc-Hk for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Jan 2019 10:37:06 +0100 Original-Received: from localhost ([127.0.0.1]:52931 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfiQH-00059c-3b for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Jan 2019 04:39:17 -0500 Original-Received: from eggsout.gnu.org ([209.51.188.92]:50932 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfiQA-00059E-AA for bug-gnu-emacs@gnu.org; Sat, 05 Jan 2019 04:39:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gfiQ4-0007wl-Kq for bug-gnu-emacs@gnu.org; Sat, 05 Jan 2019 04:39:09 -0500 Original-Received: from debbugsout.gnu.org ([209.51.188.43]:50271) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gfiQ4-0007wb-Hv for bug-gnu-emacs@gnu.org; Sat, 05 Jan 2019 04:39:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gfiQ4-0000UF-2P for bug-gnu-emacs@gnu.org; Sat, 05 Jan 2019 04:39:04 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Jan 2019 09:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 33930 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 33930@debbugs.gnu.org, eliz@gnu.org, drew.adams@oracle.com Original-Received: via spool by 33930-done@debbugs.gnu.org id=D33930.15466811381847 (code D ref 33930); Sat, 05 Jan 2019 09:39:01 +0000 Original-Received: (at 33930-done) by debbugs.gnu.org; 5 Jan 2019 09:38:58 +0000 Original-Received: from localhost ([127.0.0.1]:47237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfiPy-0000Tj-F6 for submit@debbugs.gnu.org; Sat, 05 Jan 2019 04:38:58 -0500 Original-Received: from eggsout.gnu.org ([209.51.188.92]:57280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfiPx-0000Tb-6l for 33930-done@debbugs.gnu.org; Sat, 05 Jan 2019 04:38:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gfiPr-0007mC-GW for 33930-done@debbugs.gnu.org; Sat, 05 Jan 2019 04:38:56 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfiPp-0007kp-JU; Sat, 05 Jan 2019 04:38:49 -0500 Original-Received: from [176.228.60.248] (port=4011 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gfiPo-0006hK-VX; Sat, 05 Jan 2019 04:38:49 -0500 In-reply-to: <081600a4-0b81-4123-9214-c6db840e8169@default> (message from Drew Adams on Sun, 30 Dec 2018 11:37:28 -0800 (PST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154155 Archived-At: > Date: Sun, 30 Dec 2018 11:37:28 -0800 (PST) > From: Drew Adams > > If you have used the mouse at all during the last 300 events then `C-x > C-k l' (`kmacro-edit-lossage') is broken: it just raises an error, > rather than showing you your keyboard events as a keyboard macro and > letting you edit the macro. That's not very helpful. > > This happens because `edmacro-fix-menu-commands' just punts, not > bothering to try to handle mouse events the same way it handles events > such as help-echo and switch-frame events. > > The attached patch fixes that. It also makes the error message explicit > about any unsupported event, instead of assuming that every unsupported > event is necessarily a mouse event. Thanks, installed on the master branch.