unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 33930-done@debbugs.gnu.org
Subject: bug#33930: 26.1; [PATCH] Fix `C-x C-k l' (`kmacro-edit-lossage') so it ignores mouse events
Date: Sat, 05 Jan 2019 11:38:29 +0200	[thread overview]
Message-ID: <83k1jj1m22.fsf@gnu.org> (raw)
In-Reply-To: <081600a4-0b81-4123-9214-c6db840e8169@default> (message from Drew Adams on Sun, 30 Dec 2018 11:37:28 -0800 (PST))

> Date: Sun, 30 Dec 2018 11:37:28 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
> 
> If you have used the mouse at all during the last 300 events then `C-x
> C-k l' (`kmacro-edit-lossage') is broken: it just raises an error,
> rather than showing you your keyboard events as a keyboard macro and
> letting you edit the macro.  That's not very helpful.
> 
> This happens because `edmacro-fix-menu-commands' just punts, not
> bothering to try to handle mouse events the same way it handles events
> such as help-echo and switch-frame events.
> 
> The attached patch fixes that.  It also makes the error message explicit
> about any unsupported event, instead of assuming that every unsupported
> event is necessarily a mouse event.

Thanks, installed on the master branch.





      reply	other threads:[~2019-01-05  9:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-30 19:37 bug#33930: 26.1; [PATCH] Fix `C-x C-k l' (`kmacro-edit-lossage') so it ignores mouse events Drew Adams
2019-01-05  9:38 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k1jj1m22.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=33930-done@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).