From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34765: 26.1; with-temp-buffer should not run buffer-list-update-hook Date: Wed, 24 Apr 2019 14:12:59 +0300 Message-ID: <83k1fj3bd0.fsf@gnu.org> References: <5C7FD591.9090505@gmx.at> <83lg1sc8ob.fsf@gnu.org> <5C8009F3.5000405@gmx.at> <767e1b59-6ac2-cd11-076e-82a56ac53e29@gmx.at> <831s1t57q9.fsf@gnu.org> <91d6aceb-5615-5706-99b8-d7f649c5ad87@gmx.at> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="9515"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34765@debbugs.gnu.org, alexanderm@web.de, monnier@IRO.UMontreal.CA To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 24 13:26:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hJG2U-0002NX-OG for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Apr 2019 13:26:10 +0200 Original-Received: from localhost ([127.0.0.1]:39886 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJG2T-00081k-Py for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Apr 2019 07:26:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJG2H-0007or-9h for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 07:25:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJFql-0006Y1-UV for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 07:14:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41617) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJFql-0006Xj-PA for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 07:14:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hJFql-0005HC-Gr for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 07:14:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Apr 2019 11:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34765 X-GNU-PR-Package: emacs Original-Received: via spool by 34765-submit@debbugs.gnu.org id=B34765.155610439320212 (code B ref 34765); Wed, 24 Apr 2019 11:14:02 +0000 Original-Received: (at 34765) by debbugs.gnu.org; 24 Apr 2019 11:13:13 +0000 Original-Received: from localhost ([127.0.0.1]:55158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJFpx-0005Fw-Hd for submit@debbugs.gnu.org; Wed, 24 Apr 2019 07:13:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJFpt-0005Fi-QI for 34765@debbugs.gnu.org; Wed, 24 Apr 2019 07:13:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJFpo-0004Qt-8C; Wed, 24 Apr 2019 07:13:04 -0400 Original-Received: from [176.228.60.248] (port=2489 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hJFpn-0004dH-Mw; Wed, 24 Apr 2019 07:13:04 -0400 In-reply-to: <91d6aceb-5615-5706-99b8-d7f649c5ad87@gmx.at> (message from martin rudalics on Wed, 24 Apr 2019 09:27:59 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158174 Archived-At: > Cc: 34765@debbugs.gnu.org, alexanderm@web.de, monnier@IRO.UMontreal.CA > From: martin rudalics > Date: Wed, 24 Apr 2019 09:27:59 +0200 > > >> Stefan asked me to add a variable 'inhibit-buffer-list-update-hook' > >> and I came up with the attached. WDYT? > > > > Did he also ask you to remove the inhibit_buffer_hooks flag of the > > buffer object? I'd rather prefer that you set that flag for temporary > > buffers. In any case, removing the flag will get back the problem > > with hidden buffers used by coding.c, right? I don't want to lose > > that. > > FWIW handling of the the inhibit_buffer_hooks flag is unaffected by my > patch. You are right, sorry. > > More generally, I don't understand the need for this variable. If we > > just want to inhibit the hooks for temporary buffers, we don't need to > > provide a variable, we can do that internally and unconditionally. > > The variable assumes there are other legitimate use cases where a Lisp > > program would want to inhibit the hooks, and that we agree to let Lisp > > programs do that. What are those use cases? > > I don't know. The one we care about in the case at hand is that of > 'with-temp-buffer' which seems innocuous enough for being used in the > body of a function run by 'buffer-list-update-hook'. Since that macro > is in subr.el and as such cannnot easily set the inhibit_buffer_hooks > flag, the 'inhibit-buffer-list-update-hook' variable provides a simple > workaround. I meant to suggest that get-buffer-create sets this flag when the name of the buffer fits the template of temporary buffers. Exactly like it does for code-conversion buffers now.