From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36431: Crash in marker.c:337 Date: Wed, 03 Jul 2019 07:55:18 +0300 Message-ID: <83k1czd8eh.fsf@gnu.org> References: <20190629.131734.877718102639559715.wl@gnu.org> <831rzch9nd.fsf@gnu.org> <83zhm0fuqg.fsf@gnu.org> <83ftnrf87e.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="158072"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36431@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 03 06:56:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hiXJg-000f2M-PF for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Jul 2019 06:56:24 +0200 Original-Received: from localhost ([::1]:60756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiXJf-0000CD-Po for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Jul 2019 00:56:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59694) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiXJN-0000B5-FZ for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2019 00:56:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiXJL-0002J8-NA for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2019 00:56:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39481) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hiXJK-0002I8-Js for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2019 00:56:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hiXJK-0007bN-G4 for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2019 00:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Jul 2019 04:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36431 X-GNU-PR-Package: emacs Original-Received: via spool by 36431-submit@debbugs.gnu.org id=B36431.156212974029189 (code B ref 36431); Wed, 03 Jul 2019 04:56:02 +0000 Original-Received: (at 36431) by debbugs.gnu.org; 3 Jul 2019 04:55:40 +0000 Original-Received: from localhost ([127.0.0.1]:48302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiXIx-0007aj-Pg for submit@debbugs.gnu.org; Wed, 03 Jul 2019 00:55:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiXIw-0007aV-6k for 36431@debbugs.gnu.org; Wed, 03 Jul 2019 00:55:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hiXIq-0001ic-OF; Wed, 03 Jul 2019 00:55:32 -0400 Original-Received: from [176.228.60.248] (port=1591 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hiXIp-000715-PH; Wed, 03 Jul 2019 00:55:32 -0400 In-reply-to: (message from Stefan Monnier on Wed, 03 Jul 2019 00:21:54 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162005 Archived-At: > From: Stefan Monnier > Cc: wl@gnu.org, 36431@debbugs.gnu.org > Date: Wed, 03 Jul 2019 00:21:54 -0400 > > - move_gap_both (PT, PT_BYTE); > - GAP_SIZE += inserted; > - ZV_BYTE -= inserted; > - Z_BYTE -= inserted; > - ZV -= inserted; > - Z -= inserted; > + if (ingap) > + { /* Text is at beginning of gap, move it to the end. */ > + memmove (GAP_END_ADDR - inserted, GPT_ADDR, inserted); > + } > + else > + { /* Text is inside the buffer; move it to end of the gap. */ > + move_gap_both (PT, PT_BYTE); > + eassert (inserted == Z_BYTE - BEG_BYTE); > + GAP_SIZE += inserted; > + ZV = Z = GPT = BEG; > + ZV_BYTE = Z_BYTE = GPT_BYTE = BEG_BYTE; > + /* Now we are safe to change the buffer's multibyteness directly. */ > + bset_enable_multibyte_characters (current_buffer, multibyte); > + } > + Why did you prefer to use memmove instead of move_gap_both? AFAIK the latter actually does the former under the hood, but why expose that implementation detail outside of insdel.c?