From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Wed, 23 Oct 2019 18:39:36 +0300 Message-ID: <83k18vzd1j.fsf@gnu.org> References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <87k194fvn7.fsf@mail.linkov.net> <871rvceeqp.fsf@mail.linkov.net> <83tv88cyic.fsf@gnu.org> <83pniwcvon.fsf@gnu.org> <87pniw30td.fsf@mail.linkov.net> <4dc05091-53db-bff9-4623-0aedd9c2907f@gmx.at> <6f01b03d-7be3-71cc-ff97-c1a4f7b3c213@yandex.ru> <83tv879vy0.fsf@gnu.org> <6bc27f9f-e701-afb8-c6f1-408f471187c7@yandex.ru> <83imon9tg3.fsf@gnu.org> <5db11c91-a216-40f6-f4c2-7b10c73532cc@yandex.ru> <83h8424ojp.fsf@gnu.org> <9fbdd8e8-4f6a-1aba-6509-d2699c82373b@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="256655"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37774@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 23 18:12:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iNJF4-0014e3-1E for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2019 18:12:10 +0200 Original-Received: from localhost ([::1]:40790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNJF1-0005al-Fg for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2019 12:12:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41739) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNIkx-0000fJ-Ix for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 11:41:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNIkw-0003PB-Ds for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 11:41:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54240) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iNIkw-0003Ov-Al for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 11:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iNIkw-0002qb-5q for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 11:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Oct 2019 15:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157184520710867 (code B ref 37774); Wed, 23 Oct 2019 15:41:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 23 Oct 2019 15:40:07 +0000 Original-Received: from localhost ([127.0.0.1]:34828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNIk1-0002p8-DE for submit@debbugs.gnu.org; Wed, 23 Oct 2019 11:40:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNIjz-0002oZ-IR for 37774@debbugs.gnu.org; Wed, 23 Oct 2019 11:40:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iNIjs-0002oS-7M; Wed, 23 Oct 2019 11:39:56 -0400 Original-Received: from [176.228.60.248] (port=2065 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iNIjr-0002m5-0o; Wed, 23 Oct 2019 11:39:56 -0400 In-reply-to: <9fbdd8e8-4f6a-1aba-6509-d2699c82373b@yandex.ru> (message from Dmitry Gutov on Wed, 23 Oct 2019 15:47:23 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170075 Archived-At: > Cc: 37774@debbugs.gnu.org > From: Dmitry Gutov > Date: Wed, 23 Oct 2019 15:47:23 +0300 > > > I don't know, as I don't have a clear idea what faces there are > > affected and why. I hoped someone, preferably the Magit developers, > > would describe that in enough detail to understand the situation. > > The list of faces has been posted here already: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37774#233 AFAIU, that's a list of faces one particular user decided to customize to have them extended. It's a far cry from the list of faces that actually need to be extended, lest some important functionality will suffer. IOW, we need some rationale for each face, so that we could consider that and decide whether or not to extend each one by default. Besides, some of those in the list were already changed. If too many faces in unbundled packages indeed need to change in that way, we should consider additional measures. That's why we need good reasons for extending each face, not just "because they were before" or because people were used to see them extended. > As apparent from their names, most of them are used in a Diff output > buffer, similar to our diff-mode faces. Most, but not all. And I'm not yet convinced that every face with "diff" in it must indeed be extended, we need to see examples of their display, and we need to talk about that. > In anticipation of your next question: no, they don't inherit from any > of the diff-mode faces. I know.