From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39291: M-: history doesn't store erroneous input Date: Thu, 30 Jan 2020 16:14:42 +0200 Message-ID: <83k159m3ot.fsf@gnu.org> References: <87mua7b1dm.fsf@mail.linkov.net> <83sgjymbdy.fsf@gnu.org> <87blqm0x0f.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="86015"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39291@debbugs.gnu.org, pogonyshev@gmail.com, juri@linkov.net To: Federico Tedin , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 30 15:15:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ixAb8-000MKm-MV for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Jan 2020 15:15:10 +0100 Original-Received: from localhost ([::1]:33154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixAb7-0004Fe-IQ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Jan 2020 09:15:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60091) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixAb0-0004FV-Si for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 09:15:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixAaz-0001oe-Uv for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 09:15:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57354) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ixAaz-0001oN-SA for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 09:15:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ixAaz-0005Li-Js for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 09:15:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Jan 2020 14:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39291 X-GNU-PR-Package: emacs Original-Received: via spool by 39291-submit@debbugs.gnu.org id=B39291.158039369420536 (code B ref 39291); Thu, 30 Jan 2020 14:15:01 +0000 Original-Received: (at 39291) by debbugs.gnu.org; 30 Jan 2020 14:14:54 +0000 Original-Received: from localhost ([127.0.0.1]:35094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixAas-0005LA-3P for submit@debbugs.gnu.org; Thu, 30 Jan 2020 09:14:54 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixAap-0005Kw-Nb for 39291@debbugs.gnu.org; Thu, 30 Jan 2020 09:14:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ixAag-0001TX-US; Thu, 30 Jan 2020 09:14:42 -0500 Original-Received: from [176.228.60.248] (port=4727 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ixAag-0004jc-87; Thu, 30 Jan 2020 09:14:42 -0500 In-reply-to: <87blqm0x0f.fsf@gmail.com> (message from Federico Tedin on Wed, 29 Jan 2020 22:32:16 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175436 Archived-At: > From: Federico Tedin > Cc: Juri Linkov , 39291@debbugs.gnu.org, pogonyshev@gmail.com > Date: Wed, 29 Jan 2020 22:32:16 +0100 > > I found that the minibuffer input string in `read_minibuf' was being > added to the history list after we tried to parse an object from it (if > `expflag' was true). So if the parsing failed, then the value wasn't > added to the history. I'm attaching a patch with my changes. Thanks. > My only doubt is that now, the call to `string_to_object' (which calls > `read-from-string', which calls `read1', and then `read0') is located > outside the context (not sure what the right term is) set up with > `specbind'. Could this be a problem? Do any of these functions depend on > the context set up in `read_minibuf'? (They don't appear to, just want > to be sure). Why is it a problem to move the call to unbind_to to after the call to add-to-history? AFAIU, the original code, before you changed it, actually did that. It just didn't call string_to_object, but I'm not sure why would that change anything. Does anyone see a problem here? Stefan, any comments?